Looks fine to me.
Do you want to consider a similar conversion on BulkCipher? Maybe in a
new bug.
Thanks,
Xuelei
On 3/12/2015 7:55 AM, Jamil Nimeh wrote:
> Hello all,
>
> This bug moves the internal MacAlg concrete class to an enum, and alters
> the CipherSuite constructor to no longer use Str
Or we could just take care of it now, since I'm already making enums out
of things.
http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.02/
I don't see any differences in jtreg results across the 211 ssl tests I
ran so that seems like a good sign. I've got a jprt run going now to
see i
On 3/14/2015 6:54 PM, Jamil Nimeh wrote:
> Or we could just take care of it now, since I'm already making enums out
> of things.
>
> http://cr.openjdk.java.net/~jnimeh/reviews/6996366/webrev.02/
>
Looks fine to me.
> I don't see any differences in jtreg results across the 211 ssl tests I
> ran s
One disadvantage of enum to constant is that third-party library will not be
able to extend it. I noticed this when I was trying to extend TLS to use
non-certificate-based ciphersuites by providing more KeyExchange values. That
work is stalled now but if we want to do it later this should be con
