OCSPNonceExtension.java
===
- nonceData = (byte[])obj;
+ nonceData = ((byte[])obj).clone();
Do you want to check null obj?
- return nonceData;
+ return (nonceData != null ? nonceData.clone() : null);
I think you may want to enclose the "!=" operator as:
+
Hello Sean,
Thanks! Will move the brace before commit.
Regards,
Alexander
On 8/24/2015 10:00 PM, Sean Mullan wrote:
On line 105 of RC5ParameterSpec, can you move the closing brace at the
start of the line to the end of the previous line? Otherwise,
everything else looks fine.
--Sean
On 08/
Is it necessary for the class to implement CertAttrSet? I realize all of
the internal X.509 extensions implement that, but that was done a long
time ago and not something we really want to carry forward if not
needed. I think it would be cleaner not to do that as it would more
easily allow you
Hi Sean,
Yes, I was just following Extension convention in terms of implementing
CertAttrSet. Within sun.security.x509, X509CertInfo uses the set
methods from other objects implementing CertAttrSet. But
OCSPNonceExtension really isn't a certificate attribute so it probably
doesn't need to br
On 08/18/2015 09:01 PM, Xuelei Fan wrote:
Hi Rajan,
Sorry for the delay. The code looks fine to me. I was just wondering,
what's the purpose for the V1toV3Cert.java test? Is it practice behavior?
I had the same question. I would remove this test as it seems like a
obscure case not supporte
On 8/25/15 10:09 AM, Sean Mullan wrote:
On 08/18/2015 09:01 PM, Xuelei Fan wrote:
Hi Rajan,
Sorry for the delay. The code looks fine to me. I was just wondering,
what's the purpose for the V1toV3Cert.java test? Is it practice
behavior?
I had the same question. I would remove this test a
Hi Valerie,
Thanks for comments! I have fixed all of them.
http://cr.openjdk.java.net/~rhalade/8048601/webrev.01/
- Rajan
On 8/20/15 4:19 PM, Valerie Peng wrote:
Rajan,
Here are some comments for the other half of the webrev:
TestCipherTextLength.java
1) line 82 and 85, why TEXT_LEN is neede
