Hi,
On Sat, Sep 19, 2015 at 7:15 AM, Bradford Wetmore
wrote:
> Here is the new webrev:
>
> http://cr.openjdk.java.net/~wetmore/8051498/webrev.12/
>
> Unless there are major objections, we need to get ALPN into JDK very soon to
> make JDK 9. We can still tweak the APIs if something is found l
Hi Max,
Thanks for your comments ,please check updated webrev and my replies
inline.
webrev: http://cr.openjdk.java.net/~amjiang/8050427/webrev.02/
Regards,
Amanda
On 8/17/15, 12:29 AM, Weijun Wang wrote:
There are something I don't understand.
MyConfiguration.java:
- optionOrder: Is it po
On 09/18/2015 08:37 PM, Valerie Peng wrote:
Sean,
I have updated the webrev based on your suggestions and CCC has also
been filed:
Webrev: http://cr.openjdk.java.net/~valeriep/8130648/webrev.00/
SunPKCS11.java
110: can use diamond operator for anon classes now, ex:
PrivilegedExceptionAction
Hi, Sean,
Thanks for the comments, I have changed to use the <> for line 110.
For line 116-118, the difference is in the security check. With the
current changes, the new provider will need to be granted
|SecurityPermission("authProvider.name")| for the configuration call to
complete and retur
Hi, Tristan,
The updated webrev addressed most of my previous comments except the few
that I noted below:
- Can u please make sure that all the Cipher objects are retrieved using
"SunJCE" provider? At least the AESPBEWrapper.java, CICOSkipTest.java
(there may be more as I didn't check all)
OK, the code is much easier to understand now.
In some places, there are modern and simple ways to code. For example,
in SmartLoginModule.java,
170 // verify the username/password
171 boolean usernameCorrect = false;
172 boolean passwordCorrect = true;
173 i
> This new proposal still requires that ciphers are sorted in a way that
> matches the ApplicationProtocol order.
> Would be nice if, along with the HTTP/2 blacklist, there is a HTTP/2
> comparator that sorts ciphers putting the blacklisted ones at the end.
Hm...is the sample code at the end of
Hi Valerie,
Thanks for your comments.
Please review the updated patch at
http://cr.openjdk.java.net/~fyuan/jjiang/8075286/webrev.01/
Best regards,
John Jiang
On 2015/9/12 7:50, Valerie Peng wrote:
Mostly are fine, just a few comments:
1) the convention is to place the regression tests based
