Re: Design review: JEP 273: DRBG-Based SecureRandom Implementations

2015-11-12 Thread Sean Mullan
Hi Max, Still reviewing, but a couple of initial comments .. On 11/09/2015 09:54 AM, Wang Weijun wrote: Hi All The following is API/SPI to support NIST 800-90A DRBGs. The JEP is at https://bugs.openjdk.java.net/browse/JDK-8051408 Some notes before the text: 1. Mainly, new methods are add

Re: RFR: JDK-8134577 - Eliminate or standardize a replacement for sun.net.spi.nameservice.NameServiceDescriptor

2015-11-12 Thread Mark Sheppard
Hi, based on feedback from first review the updates have been amended please oblige and review the current set of changes as per http://cr.openjdk.java.net/~msheppar/8134577/webrev.02/ regards Mark On 25/10/2015 23:32, Mark Sheppard wrote: Hi, please oblige and review the following chan

Re: RFR: [JDK-8072463] Remove requirement that AKID and SKID have to match when building certificate chain

2015-11-12 Thread Xuelei Fan
Looks fine to me. Xuelei On 11/10/2015 10:57 PM, Sean Mullan wrote: Please review this fix for a regression that removes the requirement that a certificate's Authority Key Identifier must match the issuing certificate's Subject Key Identifier when building a certificate chain. The certificate

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-12 Thread Wang Weijun
> On Nov 13, 2015, at 7:12 AM, Langer, Christoph > wrote: > > Hi Vincent, > > I just updated the changeset with a > testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/ > > The testcase would run through with or without my patch, unless you specify > the IAIK provider as explai

Re: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-12 Thread Wang Weijun
Also there is a standard way to check if it's windows: http://openjdk.java.net/jtreg/tag-spec.html#requires_names os.family should be the one to use. --Max > >> I just updated the changeset with a >> testcase:http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/ >>

RE: RFR 8139436: sun.security.mscapi.KeyStore might load incomplete data

2015-11-12 Thread Langer, Christoph
Hi Vincent, I just updated the changeset with a testcase: http://cr.openjdk.java.net/~clanger/webrevs/8139436.3/ The testcase would run through with or without my patch, unless you specify the IAIK provider as explained in the test description. Can the fix be pushed now? Thanks Chris

Re: Design review: JEP 273: DRBG-Based SecureRandom Implementations

2015-11-12 Thread Wang Weijun
> On Nov 12, 2015, at 11:23 PM, Sean Mullan wrote: > > Hi Max, > > Still reviewing, but a couple of initial comments .. > > On 11/09/2015 09:54 AM, Wang Weijun wrote: >> Hi All >> >> The following is API/SPI to support NIST 800-90A DRBGs. The JEP is at >> >> https://bugs.openjdk.java.net/b