* SSLSocketImpl.java
2100 // ONLY used by ClientHandshaker for the server hostname during
handshaling
typo: handshaking
2114 synchronized private void useImplicitHost(boolean noSniUpdate) {
the modifier order should be "private synchronized ..."
See: http://cr.openjdk.java.net/~alund
> On Apr 20, 2016, at 12:53 PM, Xuelei Fan wrote:
>
> On 4/20/2016 12:00 PM, Wang Weijun wrote:
>>
>>> On Apr 20, 2016, at 11:34 AM, Xuelei Fan wrote:
>>>
>>> On 4/19/2016 9:09 PM, Xuelei Fan wrote:
On 4/15/2016 9:
> http://cr.openjdk.java.net/~weijun/8051408/webrev.10/
>>>
>>> src
> On Apr 20, 2016, at 12:00 PM, Wang Weijun wrote:
>
>> src/java.base/share/classes/sun/security/provider/AbstractDrbg.java
>> ===
>> line 66-68: My understanding is that ...
>>
>> I would suggest rewords or remove this sentence.
This is quite convenient. We not cover the other modules?
exports sun.security.action to
java.desktop,
java.security.jgss,
jdk.crypto.pkcs11;
Thanks
Max
> On Apr 20, 2016, at 10:44 PM, Claes Redestad
> wrote:
>
> Hello,
>
> now that the sun.security.action package
On 4/20/2016 10:14 PM, Wang Weijun wrote:
>
>> On Apr 20, 2016, at 12:53 PM, Xuelei Fan wrote:
>>
>> On 4/20/2016 12:00 PM, Wang Weijun wrote:
>>>
On Apr 20, 2016, at 11:34 AM, Xuelei Fan wrote:
On 4/19/2016 9:09 PM, Xuelei Fan wrote:
> On 4/15/2016 9:
>> http://cr.openjdk
Thanks for the comments, all looks reasonable to me.
Updated webrev: http://cr.openjdk.java.net/~xuelei/8144566/webrev.02/
Thanks,
Xuelei
On 4/20/2016 9:10 PM, Sean Mullan wrote:
> * SSLSocketImpl.java
>
> 2100 // ONLY used by ClientHandshaker for the server hostname during
> handshaling
>
Thanks for looking at this, Ulf!
On 2016-04-20 17:57, Ulf Zibis wrote:
Hi,
here my comments:
Am 20.04.2016 um 16:44 schrieb Claes Redestad:
Hello,
now that the sun.security.action package is encapsulated we can
simplify internal code to get System properties.
Bug: https://bugs.openjdk.jav
New JEP Candidate: http://openjdk.java.net/jeps/287
- Mark
New JEP Candidate: http://openjdk.java.net/jeps/288
- Mark
On 04/15/2016 05:02 PM, Michael StJohns wrote:
On 4/15/2016 5:33 PM, Jamil Nimeh wrote:
Hi Mike, thanks for your comments and suggestions, I need to digest
some of this but I have some follow-up questions to start:
On 04/15/2016 12:54 PM, Michael StJohns wrote:
Hi Jamil -
I need to look at
Hi Claes, thanks.
Am 20.04.2016 um 18:12 schrieb Claes Redestad:
Thanks for looking at this, Ulf!
- Isn't the "theProp" naming style something from an old usage where all members have been named
myXyz? I more would like "propName" or just "property".
I chose to go with keeping names in line
Hello,
now that the sun.security.action package is encapsulated we can simplify
internal code to get System properties.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
Webrev: http://cr.openjdk.java.net/~redestad/8154231/webrev.01/
This adds a few convenience methods to GetPropertyActio
On 2016-04-20 16:58, Wang Weijun wrote:
This is quite convenient.
Glad you like it!
We not cover the other modules?
exports sun.security.action to
java.desktop,
java.security.jgss,
jdk.crypto.pkcs11;
I was worried I included too many changes in this patch as
On 4/20/2016 1:40 PM, Jamil Nimeh wrote:
On 04/15/2016 05:02 PM, Michael StJohns wrote:
On 4/15/2016 5:33 PM, Jamil Nimeh wrote:
Hi Mike, thanks for your comments and suggestions, I need to digest
some of this but I have some follow-up questions to start:
On 04/15/2016 12:54 PM, Michael StJ
On 20 Apr 2016, at 15:44, Claes Redestad wrote:
> Hello,
>
> now that the sun.security.action package is encapsulated we can simplify
> internal code to get System properties.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
> Webrev: http://cr.openjdk.java.net/~redestad/8154231/webr
175: Should we add DRBG:SUN as a backup for non-windows?
If NativePRNGBlocking:SUN is not always available, yes we can.
It should be available, unless someone decides to blow away
/dev/(u)random. But then DRBG will have the same problem.
One advantage about listing it here is that deplo
On 2016-04-20 20:51, Chris Hegarty wrote:
On 20 Apr 2016, at 15:44, Claes Redestad wrote:
Hello,
now that the sun.security.action package is encapsulated we can simplify
internal code to get System properties.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154231
Webrev: http://cr.openjdk
Please provide your review of following patch to this test to start
server in a separate thread, have additional logging and few other nits.
Old test didn't have enough logging at the time of failure so it is not
clear why client didn't connect which resulted in timeout on server accept.
Bug:
> On Apr 21, 2016, at 3:06 AM, Bradford Wetmore
> wrote:
>
>
>>> 175: Should we add DRBG:SUN as a backup for non-windows?
>>
>> If NativePRNGBlocking:SUN is not always available, yes we can.
>
> It should be available, unless someone decides to blow away /dev/(u)random.
> But then DRBG wi
> On Apr 20, 2016, at 11:13 PM, Xuelei Fan wrote:
>
>> Really? You are worried about more than 2^64 instances of DRBG?
>>
> SSL/TLS considers record sequence number wrapping, too. The nonce
> require at least half-strength randomness, I would like to follow this
> requirement.
>
>> How about
On 4/20/2016 4:30 PM, Wang Weijun wrote:
198: Should we add a short 1-liner description for the fields? The
variable meanings (esp pr/df) may not be obvious to a casual observer.
For example, using these three fields as an example:
mech_name: default "Hash_DRBG"
"Hash_DRBG" | "H
On 4/21/2016 7:55 AM, Wang Weijun wrote:
>
>> On Apr 20, 2016, at 11:13 PM, Xuelei Fan wrote:
>>
>>> Really? You are worried about more than 2^64 instances of DRBG?
>>>
>> SSL/TLS considers record sequence number wrapping, too. The nonce
>> require at least half-strength randomness, I would like
You made a few update of the coding style, for example line 60-62, which
is different from the traditional coding. Are you following some coding
conventions?
As if you are already there, maybe you can do more revise.
1. although it is a test, most of the methods and fields can be private.
2. woul
> On Apr 21, 2016, at 8:07 AM, Xuelei Fan wrote:
>
>> I'll model after Authenticator. That would need some synchronization.
>>
> You have already make synchronization.
You mean synchronized for instantiateIfNecessary? But this time I need to
synchronize on cc which is static.
>
>> I even da
On 4/21/2016 9:24 AM, Wang Weijun wrote:
>
>> On Apr 21, 2016, at 8:07 AM, Xuelei Fan wrote:
>>
>>> I'll model after Authenticator. That would need some synchronization.
>>>
>> You have already make synchronization.
>
> You mean synchronized for instantiateIfNecessary? But this time I need to
>
> On Apr 20, 2016, at 9:35 AM, Xuelei Fan wrote:
>
> On 4/20/2016 9:17 AM, Wang Weijun wrote:
>>
>>> On Apr 20, 2016, at 7:41 AM, Xuelei Fan wrote:
>>>
>>> On 4/19/2016 11:41 PM, Wang Weijun wrote:
http://cr.openjdk.java.net/~weijun/8051408/webrev.10/
>>
>> Please update cop
Thanks for your comments!
Updated webrev: http://cr.openjdk.java.net/~rhalade/8129329/webrev.01/
On 4/20/16 5:23 PM, Xuelei Fan wrote:
You made a few update of the coding style, for example line 60-62, which
is different from the traditional coding. Are you following some coding
conventions?
I
27 matches
Mail list logo
