[9] RFR:8160339 Remove intermittent key from javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java

2016-07-06 Thread Tim Du
Hi, Please help to review the path for "8160339:Remove intermittent key from javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java ", JDK-8049314 has been fixed, and no bug is tracking issue on this test, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JD

Re: [9] RFR:8160339 Remove intermittent key from javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java

2016-07-06 Thread Xuelei Fan
looks fine to me. Xuelei > On Jul 6, 2016, at 3:36 PM, Tim Du wrote: > > Hi, > > Please help to review the path for "8160339:Remove intermittent key from > javax/net/ssl/templates/SSLSocketSSLEngineTemplate.java ", JDK-8049314 has > been fixed, and no bug is tracking issue on this test, @key

[9] RFR:8160337 Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java

2016-07-06 Thread Tim Du
Hi All, Would you help to review the path for "8160337:Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java"? JDK-8074580 has been fixed, @key intermittent can be removed.Thanks. JBS: https://bugs.openjdk.java.net/browse/JDK-8160337 webrev: http://cr.openjdk.java.net

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Alan Bateman
On 06/07/2016 05:32, Weijun Wang wrote: On 7/5/2016 23:50, Mandy Chung wrote: Max - are you running the test with exploded image (see JDK-8155858 [1])? No. The test also fails with recent promoted builds (ever since java.sql is de-priveleged). I assume this is a general issue with security

Re: [9] RFR 8157667: sun/security/x509/URICertStore/ExtensionsWithLDAP.java has to be updated due to JDK-8134577

2016-07-06 Thread Sean Mullan
On 07/01/2016 09:38 AM, John Jiang wrote: Ping again ;-) Looks good. My only comment is that SocksProxy.java might be generally useful for other tests, so it may make sense later on to move it to jdk/test/java/security/testlibrary, but no action is needed right now. --Sean John Jiang O

Re: [9] RFR: JDK-7052815 Finish checking of 7052537

2016-07-06 Thread Sean Mullan
Could you add a more descriptive title for this bug report than "Finish checking of 7052537"? How about "Change tests that remove providers to run in othervm mode". Also, have you also checked if there are tests that just add their own provider but don't remove it? This could also potentially

RFR: JDK-8129972 (Clarify the javadoc for CodeSource)

2016-07-06 Thread Jamil Nimeh
Hello all, This is a quick webrev to clarify the behavior in the javadoc for a null URL input in the CodeSource constructors. There are a few other minor javadoc nit fixes too. Bug: https://bugs.openjdk.java.net/browse/JDK-8129972 Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8129972/we

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

2016-07-06 Thread Valerie Peng
Changes look fine to me. Thanks, Valerie On 7/5/2016 2:31 PM, Mandy Chung wrote: On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline wrote: On Jul 5, 2016, at 1:36 PM, Mandy Chung wrote: On Jul 5, 2016, at 12:42 PM, Alexandre (Shura) Iline wrote: This made sense, than you, Mandy. P

Re: [9] RFR:8160337 Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairGenerator.java

2016-07-06 Thread Rajan Halade
Hi Tim, Thanks for taking care of this one. Since the test is still using random data key "randomness" should be retained. Thanks, Rajan On 7/6/16 1:04 AM, Tim Du wrote: Hi All, Would you help to review the path for "8160337:Remove intermittent key from sun/security/pkcs11/rsa/TestKeyPairG

Re: RFR: 8158670: Fix @modules in java/lang/SecurityManager/CheckSecurityProvider.java

2016-07-06 Thread Alexandre (Shura) Iline
Valerie, could you sponsor the patch for me? Shura > On Jul 6, 2016, at 10:08 AM, Valerie Peng wrote: > > > Changes look fine to me. > Thanks, > Valerie > > On 7/5/2016 2:31 PM, Mandy Chung wrote: >>> On Jul 5, 2016, at 1:53 PM, Alexandre (Shura) Iline >>> wrote: >>> >>> On Jul 5, 20

Re: RFR: JDK-8129972 (Clarify the javadoc for CodeSource)

2016-07-06 Thread Sean Mullan
Looks good. Add a noreg-doc label to the bug. --Sean On 07/06/2016 12:54 PM, Jamil Nimeh wrote: Hello all, This is a quick webrev to clarify the behavior in the javadoc for a null URL input in the CodeSource constructors. There are a few other minor javadoc nit fixes too. Bug: https://bugs.o

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Sean Mullan
On 07/06/2016 04:51 AM, Alan Bateman wrote: On 06/07/2016 05:32, Weijun Wang wrote: On 7/5/2016 23:50, Mandy Chung wrote: Max - are you running the test with exploded image (see JDK-8155858 [1])? No. The test also fails with recent promoted builds (ever since java.sql is de-priveleged). I

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
> On Jul 7, 2016, at 5:04 AM, Sean Mullan wrote: > > Does your SSL code match up with the stack trace? The test only has 27 lines, > but the stack trace says it was called from line 42. My local SSL.java still contains the GPL comments and I didn't paste them here. Line 42 is

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
> On Jul 7, 2016, at 8:19 AM, Peter Firmstone > wrote: > > Perhaps the policy provider hasn't been refreshed when the new security > manager is in force? Try doing a Policy.refresh() in the SecurityManager > constructor. You mean Policy.getPolicy().refresh()? No difference. And I don't thi

Re: Strange test failure when referencing a class in a deprivileged module

2016-07-06 Thread Wang Weijun
I run the program directly (not from jtreg) and the result is different: Exception in thread "main" java.lang.BootstrapMethodError: call site initialization exception at SSL.checkPermission(SSL.java:21) at java.lang.SecurityManager.checkPropertyAccess(java.base@9-ea/SecurityManag