Re: [10] RFR : 8186628 : SSL session cache can cause a scalability bottleneck

2017-11-22 Thread Peter Levart
Hi Ivan, Here's my attempt to increase multithreaded scalability of Cache: http://cr.openjdk.java.net/~plevart/jdk10-dev/8186628_ssl_session_cache_scalability/webrev.01/ Haven't tested this yet, but I thought that since you already have relevant performance tests, you might want to try this, s

New JEP Draft: "Open-Source the Root Certificates"

2017-11-22 Thread Sean Mullan
Please review a new JEP Draft titled "Open-Source the Root Certificates". The JDK source code currently contains an empty cacerts keystore, which prevents security components such as TLS from working out-of-the-box on OpenJDK builds. The goal of this JEP is to provide a default set of root cer

Re: New JEP Draft: "Open-Source the Root Certificates"

2017-11-22 Thread Alan Bateman
On 22/11/2017 13:23, Sean Mullan wrote: Please review a new JEP Draft titled "Open-Source the Root Certificates". The JDK source code currently contains an empty cacerts keystore, which prevents security components such as TLS from working out-of-the-box on OpenJDK builds. The goal of this JE

Re: New JEP Draft: "Open-Source the Root Certificates"

2017-11-22 Thread dalibor topic
Thanks, Sean - this is a great step forward! On 22.11.2017 14:23, Sean Mullan wrote: Please review a new JEP Draft titled "Open-Source the Root Certificates". The JDK source code currently contains an empty cacerts keystore, which prevents security components such as TLS from working out-of-th

RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Sean Mullan
Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete since the SecurityManager was revamped in JDK 1.2. The methods to be removed are: ge

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Alan Bateman
On 22/11/2017 14:37, Sean Mullan wrote: Please review this change to remove the pre-JDK 1.2 SecurityManager methods that have been deprecated since JDK 1.2 and marked for removal in JDK 9. These methods are fragile, error-prone and have been obsolete since the SecurityManager was revamped in JD

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Sean Mullan
On 11/22/17 9:59 AM, Alan Bateman wrote: http://cr.openjdk.java.net/~mullan/webrevs/8186535/webrev.00/ This mostly looks good. Does the stack walker created in AppletSecurity need to be done in a privileged block? If this is just the mouldy appletviewer tool then ignore my comment. Hmm. Wh

Re: RFR: 8186535: Remove deprecated pre-1.2 SecurityManager methods and fields

2017-11-22 Thread Alan Bateman
On 22/11/2017 15:49, Sean Mullan wrote: Hmm. Where do you see it being called inside doPrivileged? StackWalker.getInstance does a permission check when you want class refs. : Sure, the test already had everything I need so it was easier to leverage it rather than just duplicating. I had

Re: RFR[10] 8186057: TLS interoperability testing between different Java versions

2017-11-22 Thread Artem
Hi John, Could you please upload the report to http://cr.openjdk.java.net/~jjiang/8186057 ? One question about Compatibility.caseStatus(). What's the case when you expect a timeout and no client output? Should it always result to a test case failure? Otherwise, looks fine to me. A couple

Re: [10] RFR : 8186628 : SSL session cache can cause a scalability bottleneck

2017-11-22 Thread Ivan Gerasimov
Hi Peter! Thank you very much for looking into this! On 11/22/17 1:45 AM, Peter Levart wrote: Hi Ivan, Here's my attempt to increase multithreaded scalability of Cache: http://cr.openjdk.java.net/~plevart/jdk10-dev/8186628_ssl_session_cache_scalability/webrev.01/ Haven't tested this yet, bu

Re: [10] RFR 8068024 : Null pointer dereference in jdk/src/macosx/native/apple/security/KeystoreImpl.m

2017-11-22 Thread Ivan Gerasimov
Thank you for review! Pushed. With kind regards, Ivan On 11/21/17 10:32 PM, Weijun Wang wrote: This looks fine to me. Thanks Max On Nov 22, 2017, at 9:47 AM, Ivan Gerasimov wrote: Hello! Here's a simple fix to correctly handle the malloc call returning NULL. BUGURL: https://bugs.openjdk