Re: RFR[10] 8186057: TLS interoperability testing between different Java versions

2017-11-23 Thread sha . jiang
Hi Artem, Please find the updated webrev at: http://cr.openjdk.java.net/~jjiang/8186057/webrev.05/ And see my comments inline. On 23/11/2017 02:19, Artem wrote: Hi John, Could you please upload the report to http://cr.openjdk.java.net/~jjiang/8186057 ? http://cr.openjdk.java.net/~jjiang/818

Re: RFR[10] 8186057: TLS interoperability testing between different Java versions

2017-11-23 Thread Artem
Hi John, A couple of more (probably minor) comments. Addressing them might simplify the code and make it more readable. Although, one might argue with it. So, feel free to ignore them. The only thing which I would like to clarify is the questing about timeouts below. I see you use multi-line

Dropping the security manager (was Re: Eliminating the security overhead when not running with a security manager)

2017-11-23 Thread Jason Tedor
> Long term then it would be interesting to explore degrading and eventually dropping the security manager but that is beyond the scope of what I would like to discuss here. That is a bold topic to immediately declare out of scope. I am looking for somewhere to reply, so I am forking this thread t

Re: Dropping the security manager (was Re: Eliminating the security overhead when not running with a security manager)

2017-11-23 Thread Alan Bateman
On 23/11/2017 19:21, Jason Tedor wrote: > Long term then it would be interesting to explore degrading and eventually dropping the security manager but that is beyond the scope of what I would like to discuss here. That is a bold topic to immediately declare out of scope. I am looking for some

[PATCH] JDK-8190917 : SSL session resumption, through handshake, in SSLEngine is broken for any protocols lesser than TLSv1.2

2017-11-23 Thread Jaikiran Pai
As noted in [1], there's a regression in Java 9, where SSL session resumption no longer works for SSL protocols other than TLSv1.2. The code which is responsible for session resumption resides in the ServerHandshaker[2], in the clientHello method. This method, in its logic to decide whether or

Re: RFR[10] 8186057: TLS interoperability testing between different Java versions

2017-11-23 Thread sha . jiang
Hi Artem, The test is updated again: http://cr.openjdk.java.net/~jjiang/8186057/webrev.06/ The report table is decorated. And please see more comments inline. On 24/11/2017 01:06, Artem wrote: Hi John, A couple of more (probably minor) comments. Addressing them might simplify the code and ma