RFR 8192987: keytool should remember real storetype if it is not provided

Hi All Please take a look at http://cr.openjdk.java.net/~weijun/8192987/webrev.00/ The fix delays the assignment of storetype and srcstoretype (when they are not provided on the command line) to where the actual keystore file is loaded. I could have retained lines 711-719 because we had has

Re: RFR 8192987: keytool should remember real storetype if it is not provided

Update the copyright date on KeyStoreUtil.java. Otherwise looks fine to me. --Sean On 12/7/17 3:53 AM, Weijun Wang wrote: Hi All Please take a look at http://cr.openjdk.java.net/~weijun/8192987/webrev.00/ The fix delays the assignment of storetype and srcstoretype (when they are not pro

Re: RFR 8193156 : Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903

Can you keep line 48, which was just a javadoc wording fix? Otherwise, looks ok. Please re-open or file new bugs for JDK-8058547 and JDK-8055753. Thanks, Sean On 12/6/17 8:35 PM, Ivan Gerasimov wrote: Hello! A regression caused by the recent fixes of the ProtectionDomain cache was observed.

Re: RFR 8192987: keytool should remember real storetype if it is not provided

I think my previous fix introduced a behavior change. Here is an update: http://cr.openjdk.java.net/~weijun/8192987/webrev.01/ Precisely, the "hasStoretypeOption == false" is equivalent to "storetype == null" but should not be removed. Although we can probe storetype of pkcs12/jks/jceks, tha

Re: RFR 8193156 : Need to backout fixes for JDK-8058547, JDK-8055753, JDK-8085903

Thank you Sean for review! On 12/7/17 6:10 AM, Sean Mullan wrote: Can you keep line 48, which was just a javadoc wording fix? Otherwise, looks ok. Okay, I'll keep this change. Please re-open or file new bugs for JDK-8058547 and JDK-8055753. Yes, will do. With kind regards, Ivan Thanks,

Re: RFR 8192987: keytool should remember real storetype if it is not provided

Looks good. --Sean On 12/7/17 9:39 AM, Weijun Wang wrote: I think my previous fix introduced a behavior change. Here is an update: http://cr.openjdk.java.net/~weijun/8192987/webrev.01/ Precisely, the "hasStoretypeOption == false" is equivalent to "storetype == null" but should not be rem

RFR 8192988: keytool should support -storepasswd for pkcs12 keystores

Hi All Please take a look at http://cr.openjdk.java.net/~weijun/8192988/webrev.00/ With this fix, "keytool -storepasswd" and "keytool -importkeystore" on a PKCS12 keystore will change the keypass as well with the storepass. Thanks Max

Re: RFR 8165996: PKCS11 using NSS throws an error regarding secmod.db when NSS uses sqlite

Hi Martin I'm just starting to read this patch. Two questions: 1. Is there a webpage on configDir using sql:/? 2. Your test hardcoded nssLibraryDirectory to be "/lib64". It would need to be changed to either those inclosed the repository (macOS and Windows) or in the system (others). Is there