On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
> All patches are posted to http://cr.openjdk.java.net/~weijun/twosigma-gss/.
Peter Burka (cc'ed), of Two Sigma, did a code review using our GitHub
clone:
https://github.com/twosigma/OpenJDK/pull/1
Nico
--
Please review this fix to a regression introduced in JDK 9. An
application run with a SecurityManager and using a JDK that is accessed
over the network using a UNC path fails to startup and throws an
InternalError.
The fix is to load default.policy as a regular File rather than a URL
(URLs ar
On 05/03/2019 18:57, Nico Williams wrote:
On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
All patches are posted to http://cr.openjdk.java.net/~weijun/twosigma-gss/.
Peter Burka (cc'ed), of Two Sigma, did a code review using our GitHub
clone:
Sorry, code reviews and discussions of
> On Mar 6, 2019, at 3:55 AM, Alan Bateman wrote:
>
> On 05/03/2019 18:57, Nico Williams wrote:
>> On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
>>> All patches are posted to http://cr.openjdk.java.net/~weijun/twosigma-gss/.
>> Peter Burka (cc'ed), of Two Sigma, did a code revie
The fix looks fine to me.
However, is PolicyUtil::getInputStream correct? Will it cause any problem when
a UNC path is used in -Djava.security.policy?
I've seen several code changes around UNC recently. Wonder if we've finally fix
it and PolicyUtil::getInputStream can always call url.openStream
On Wed, Mar 06, 2019 at 08:39:45AM +0800, Weijun Wang wrote:
> > On 05/03/2019 18:57, Nico Williams wrote:
> >> On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
> >>> All patches are posted to
> >>> http://cr.openjdk.java.net/~weijun/twosigma-gss/.
> >> Peter Burka (cc'ed), of Two Sigm
> On Mar 6, 2019, at 10:09 AM, Nico Williams wrote:
>
> On Wed, Mar 06, 2019 at 08:39:45AM +0800, Weijun Wang wrote:
>>> On 05/03/2019 18:57, Nico Williams wrote:
On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
> All patches are posted to
> http://cr.openjdk.java.net