> On Mar 6, 2019, at 3:55 AM, Alan Bateman <alan.bate...@oracle.com> wrote:
> 
> On 05/03/2019 18:57, Nico Williams wrote:
>> On Mon, Oct 08, 2018 at 12:35:33PM +0800, Weijun Wang wrote:
>>> All patches are posted to http://cr.openjdk.java.net/~weijun/twosigma-gss/.
>> Peter Burka (cc'ed), of Two Sigma, did a code review using our GitHub
>> clone:
>> 
> Sorry, code reviews and discussions of patches for OpenJDK need to be use the 
> OpenJDK mailing lists.

Yes, this is the rule.

Also, I'm not sure what Peter is reviewing here as the title is not clear to 
me. Is it about all patches you are contributing? Or is it about the OpenJDK 
bugs we have already filed (which is only the first few steps of the big 
contribution)?. You are OK to discuss any change you are preparing to 
contribute anywhere, but once you decide to contribute a piece of code into 
OpenJDK, please follow these steps:

1. File a bug or RFE (If you cannot do that, ask me).

2. Post the patch on cr.openjdk.java.net and ask security-dev@o.j.n for code 
review, or the patch is short, include it in the mail.

3. Anyone can reply the mail.

You might heard there is a effort [1] going on about switching to another SCM 
or hosting service, but not now yet.

Thanks,
Max

[1] https://openjdk.java.net/projects/skara/

> 
> -Alan

Reply via email to