+1
On 2/11/20 3:24 PM, Ivan Gerasimov wrote:
Thank you Roger!
We do have a manual test that performs some sanity verification that a
transmit call works [1].
I have also received a confirmation from a submitter of the bug that
the patched JDK now allows to retrieve data larger than 32k, whi
On 08/02/2020 00:10, Bradford Wetmore wrote:
> On 2/5/2020 9:40 PM, Andrew John Hughes wrote:> First of all, thanks
> again for posting these patches and also for the
>> comprehensive list of issues for both of them. They pretty much matched
>> up with what I saw when reviewing the patches
>
> G
Hi, Ivan,
I share your thought/confusion on the current impl as I am also not
familiar with ISO/IEC 7816-4.
Based on my reading of this standard and the CardImpl code, it looks
like the while-true loop is for retrieving additional response data. Per
the standard and javadoc, max length of th
Ignore my earlier comment about fixing the check.
Took a second look at the check and noticed that it's for throwing the
exception.
Your current webrev is fine.
Regards,
Valerie
On 2/12/2020 8:23 PM, Valerie Peng wrote:
Hi, Ivan,
I share your thought/confusion on the current impl as I a
Hi -
I needed to go take a quick look at 7816-3 to figure out what's what.
Basically, this code is a bit problematic.
1) Since this code doesn't support extended length APDUs for T=0, you
should never have to do multiple calls to get the responses - e.g. the
max response handled here should b