Webrev updated at
http://cr.openjdk.java.net/~weijun/8237218/webrev.03/
The test is modified. Instead of adding a hacked ECDSASignature I'm using JDI
to detect if the Java impl or the native impl is used. Two method names in
ECDSASignature are modified to ease method lookup in the test.
Tha
Please take a review at
https://cr.openjdk.java.net/~weijun/8160818/webrev.00
I haven't updated the server side to check the mutual state, for compatibility.
Thanks,
Max
Correct the subject line.
> On Feb 13, 2020, at 10:24 PM, Weijun Wang wrote:
>
> Please take a review at
>
> https://cr.openjdk.java.net/~weijun/8160818/webrev.00
>
> I haven't updated the server side to check the mutual state, for
> compatibility.
>
> Thanks,
> Max
>
Do you want to declare the mutual variable as final object? Otherwise,
looks fine to me.
Xuelei
On 2/13/2020 7:14 AM, Weijun Wang wrote:
Correct the subject line.
On Feb 13, 2020, at 10:24 PM, Weijun Wang wrote:
Please take a review at
https://cr.openjdk.java.net/~weijun/8160818/webre
Thank you Mike for the additional analysis!
I would like to avoid any significant modifications to the code at this
moment, as I have only limited resources to test them.
The last proposed patch [1] takes a conservative approach and just
increases the limit of the iterations.
So, this is hi
I think it's fine to remove this check given the recent NSS changes as
Martin mentioned.
Second Sean's release note suggestion as well.
Thanks,
Valerie
On 2/10/2020 11:14 AM, Sean Mullan wrote:
Looks good to me, although I would also like Valerie to review it as
she has the most experienc
On 2/12/2020 3:10 PM, Andrew John Hughes wrote:
I originally had this as "@since 8 MR 3" but during internal review it
was requested to use @since 8 instead. This is what was presented/voted
during the MR phase.
Ah ok. I personally think the original MR 3 version would have been
better,
It cannot be final because it was modified later on line 149.
That said, this variable is only used inside the constructor and I can make it
local. Does that sound better to you?
Thanks,
Max
> On Feb 14, 2020, at 1:24 AM, Xuelei Fan wrote:
>
> Do you want to declare the mutual variable as fin
On 2/13/2020 8:41 PM, Weijun Wang wrote:
It cannot be final because it was modified later on line 149.
I think line 149 is in the same constructor, so it is possible to
declare it as final.
That said, this variable is only used inside the constructor and I can make it
local. Does that sound
