Hi Kim,
Thanks for your review.
I tried to solve the problem with your suggestion, and have just one question.
> On 29 September 2020 18:51 PM, Kim Barrett wrote:
> I don't think using memory functions in place of string functions for string
> manipulation is really an improvement.
Yes, the ori
Hi,
> -Original Message-
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-
> r...@openjdk.java.net] On Behalf Of Andrew Haley
> Sent: Tuesday, September 29, 2020 5:25 PM
> To: core-libs-...@openjdk.java.net; hotspot-...@openjdk.java.net;
> hotspot-compiler-...@openjdk.java.net; se
Hi,
> -Original Message-
> From: hotspot-dev [mailto:hotspot-dev-r...@openjdk.java.net] On Behalf
> Of Valerie Peng
> Sent: Wednesday, September 30, 2020 6:25 AM
> To: core-libs-...@openjdk.java.net; hotspot-...@openjdk.java.net;
> hotspot-compiler-...@openjdk.java.net; security-dev@openjd
> On Sep 30, 2020, at 3:30 AM, Eric Liu wrote:
>
> Hi Kim,
>
> Thanks for your review.
> I tried to solve the problem with your suggestion, and have just one question.
>
>> On 29 September 2020 18:51 PM, Kim Barrett wrote:
>> With gcc10.2, and using the --enable-asan configure option, we get a
On 2020-09-29 13:17, Kim Barrett wrote:
On Sep 29, 2020, at 6:51 AM, Kim Barrett wrote:
On Sep 28, 2020, at 11:13 AM, Eric Liu wrote:
Hi,
Thanks for looking at this.
For gcc-10, it's hard to make 'strncpy' all right with asan enabled (approaches
we talked previous don't work).
I'm tryi
> On Sep 30, 2020, at 7:09 AM, Magnus Ihse Bursie
> wrote:
>
>
>
> On 2020-09-29 13:17, Kim Barrett wrote:
>> Another option might be to solve
>> https://bugs.openjdk.java.net/browse/JDK-8232187
>>
> Will that really help? If a os::strncpy_s method is added to hotspot, how
> should NetworkI
On Wed, 30 Sep 2020 02:59:40 GMT, Weijun Wang wrote:
> For two principals to be the same, they are either all "user@R", or one is
> "user" and the other is "user@R". The check
> here wants to fail early if the length are different. "l" is the whole length
> and "r" is the length of the name
> (
On Wed, 30 Sep 2020 02:59:40 GMT, Weijun Wang wrote:
> For two principals to be the same, they are either all "user@R", or one is
> "user" and the other is "user@R". The check
> here wants to fail early if the length are different. "l" is the whole length
> and "r" is the length of the name
> (
On Wed, 30 Sep 2020 02:59:40 GMT, Weijun Wang wrote:
> For two principals to be the same, they are either all "user@R", or one is
> "user" and the other is "user@R". The check
> here wants to fail early if the length are different. "l" is the whole length
> and "r" is the length of the name
> (
On Tue, 29 Sep 2020 11:39:20 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for
>> https://bugs.openjdk.java.net/browse/JDK-8242882?
>>
>> As noted in that JBS issue, if the size of the Manifest entry in the jar
>> happens to be very large (such that it exceeds
>
On Wed, 23 Sep 2020 15:09:44 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address the review comments and introduce an array size check in
>> JarFile.getBytes() method itself
>
> test/jdk/java
On Wed, 30 Sep 2020 17:26:18 GMT, Brent Christian wrote:
>> test/jdk/java/util/jar/JarFile/LargeManifestOOMTest.java line 60:
>>
>>> 58: final OutOfMemoryError oome =
>>> Assert.expectThrows(OutOfMemoryError.class, () -> jar.getManifest());
>>> 59: // additionally verify that th
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
> - I decided to change `@since` from
On Mon, 28 Sep 2020 19:08:04 GMT, Philippe Marschall
wrote:
>> @marschall I will sponsor it after you integrate the latest update.
>
> @vnkozlov done, I hope I now made it correctly with a merge commit for the
> latest merge conflict
hs-tier1, hs-tier3-graal testing passed
-
PR:
On Sun, 20 Sep 2020 13:54:02 GMT, Roger Riggs wrote:
> # JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter
>
> Debugging functions that utilize ASN.1, DER, and BER encoded streams is
> difficult without test utilities to show the contents.
> The ASN.1 formatter reads a stream
On Tue, 29 Sep 2020 15:20:24 GMT, Weijun Wang wrote:
>> This code change rewrites DerValue into a mostly immutable class and
>> simplifies DerInputStream as a wrapper for a
>> series of DerValues objects. DerInputBuffer is removed.
>> All existing methods of DerValue and DerInputStream should st
On Tue, 29 Sep 2020 03:09:54 GMT, Weijun Wang wrote:
>> I just wonder why the different handling. Do you know why? Is it really
>> used/needed, just curious?
>
> I don't know. Both methods are called, and `DerValue::getOctetString` is
> actual used in reality when reading content
> data embedde
Plumb new internal static factory method to trust the array passed in, avoiding
unnecessary copying. JMH results for
the benchmark show about 15% improvement for the cases that were optimized,
namely the 3 to 10 fixed arg cases.
# VM options: -verbose:gc -XX:+UseParallelGC -Xms4g -Xmx4g --enable
On Tue, 29 Sep 2020 15:20:24 GMT, Weijun Wang wrote:
>> This code change rewrites DerValue into a mostly immutable class and
>> simplifies DerInputStream as a wrapper for a
>> series of DerValues objects. DerInputBuffer is removed.
>> All existing methods of DerValue and DerInputStream should st
> This code change rewrites DerValue into a mostly immutable class and
> simplifies DerInputStream as a wrapper for a
> series of DerValues objects. DerInputBuffer is removed.
> All existing methods of DerValue and DerInputStream should still work with
> the exact same behavior, except for a few
On Thu, 1 Oct 2020 02:24:47 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev
>> excludes the unrelated changes brought in by the merge/rebase. The pull
>> request contains four additional commits si
On Thu, 1 Oct 2020 00:13:28 GMT, Stuart Marks wrote:
> Plumb new internal static factory method to trust the array passed in,
> avoiding unnecessary copying. JMH results for
> the benchmark show about 15% improvement for the cases that were optimized,
> namely the 3 to 10 fixed arg cases.
> # V
22 matches
Mail list logo
