We have a couple of calls to getpwuid_r in the codebase, like
g= getpwuid_r(getuid(), &resbuf, pwd_buf, sizeof(pwd_buf), &pwd);
Usually we NULL-check pwd after the call because we do not fully trust the
return code of the function (it is documented in the codebase why we do not
fully trust the
On Fri, 15 Jan 2021 11:24:49 GMT, Matthias Baesken wrote:
> We have a couple of calls to getpwuid_r in the codebase, like
> g= getpwuid_r(getuid(), &resbuf, pwd_buf, sizeof(pwd_buf), &pwd);
>
> Usually we NULL-check pwd after the call because we do not fully trust the
> return code of the fun
On Fri, 15 Jan 2021 13:54:15 GMT, Harold Seigel wrote:
>> We have a couple of calls to getpwuid_r in the codebase, like
>> g= getpwuid_r(getuid(), &resbuf, pwd_buf, sizeof(pwd_buf), &pwd);
>>
>> Usually we NULL-check pwd after the call because we do not fully trust the
>> return code of the f
On Mon, 11 Jan 2021 09:20:07 GMT, Magnus Ihse Bursie wrote:
>> Marked as reviewed by prr (Reviewer).
>
> This PR is not stale; it's just still waiting for input from @AlanBateman.
@magicus Can the CharacterDataXXX.template files move to
src/java.base/share/classes/java/lang?
-
PR:
> This enhancement adds support for the nonce extension in OCSP request
> extensions by system property jdk.security.certpath.ocspNonce.
>
> Please review the CSR at:
> https://bugs.openjdk.java.net/browse/JDK-8257766
Hai-May Chao has updated the pull request incrementally with one additional
c
2020/12/4 6:08:13 -0800, er...@openjdk.java.net:
> On Fri, 4 Dec 2020 12:30:02 GMT, Alan Bateman wrote:
>>> And I can certainly move jdwp.spec to java.base instead. That's the
>>> reason I need input on this: All I know is that is definitely not
>>> the responsibility of the Build Group to maintai
On Fri, 15 Jan 2021 14:58:14 GMT, Alan Bateman wrote:
>> This PR is not stale; it's just still waiting for input from @AlanBateman.
>
> @magicus Can the CharacterDataXXX.template files move to
> src/java.base/share/classes/java/lang?
@AlanBateman That sounds like an excellent idea. I'll update
On Wed, 13 Jan 2021 00:53:01 GMT, Valerie Peng wrote:
>>> For cipher impls, there are more than just P11Cipher, there are also
>>> P11AEADCipher and P11RSACipher. It looks like they should be updated with
>>> this defensive cancellation change unless the non-compliant NSS impl is
>>> algorithm
> When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an
> invalid block size), we now cancel the operation before returning the
> underlying Session to the Session Manager. This allows to use the returned
> Session for a different purpose. Otherwise, an CKR_OPERATION_ACTIVE e
> When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an
> invalid block size), we now cancel the operation before returning the
> underlying Session to the Session Manager. This allows to use the returned
> Session for a different purpose. Otherwise, an CKR_OPERATION_ACTIVE e
On Wed, 13 Jan 2021 00:53:01 GMT, Valerie Peng wrote:
>>> For cipher impls, there are more than just P11Cipher, there are also
>>> P11AEADCipher and P11RSACipher. It looks like they should be updated with
>>> this defensive cancellation change unless the non-compliant NSS impl is
>>> algorithm
> When a multi-part cipher operation fails in SunPKCS11 (i.e. because of an
> invalid block size), we now cancel the operation before returning the
> underlying Session to the Session Manager. This allows to use the returned
> Session for a different purpose. Otherwise, an CKR_OPERATION_ACTIVE e
On Thu, 14 Jan 2021 20:29:54 GMT, Valerie Peng wrote:
>> The update fails because the native mechanism (CKM_AES_ECB) has no padding
>> and OpenJDK does not buffer data in the Java side for encryption [1] (this
>> is a bug that I'll address soon). As a result, there is a PKCS#11 call with
>> an
On Sun, 20 Dec 2020 20:27:03 GMT, Claes Redestad wrote:
> - The MD5 intrinsics added by
> [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902) shows that
> the `int[] x` isn't actually needed. This also applies to the SHA intrinsics
> from which the MD5 intrinsic takes inspiration
>
> This enhancement adds support for the nonce extension in OCSP request
> extensions by system property jdk.security.certpath.ocspNonce.
>
> Please review the CSR at:
> https://bugs.openjdk.java.net/browse/JDK-8257766
Hai-May Chao has updated the pull request incrementally with one additional
c
On Thu, 14 Jan 2021 20:04:33 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/sun/security/rsa/RSAKeyFactory.java line 344:
>>
>>> 342: if (keySpec instanceof PKCS8EncodedKeySpec) {
>>> 343: return RSAPrivateCrtKeyImpl.newKey(type, "PKCS#8",
>>> 344:
On Thu, 14 Jan 2021 14:35:25 GMT, Sean Mullan wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update to use List.of() and typo changes
>
> src/java.base/share/classes/sun/security/provider/certpath/RevocationChecke
On Fri, 15 Jan 2021 22:54:32 GMT, Valerie Peng wrote:
>> - The MD5 intrinsics added by
>> [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902) shows that
>> the `int[] x` isn't actually needed. This also applies to the SHA intrinsics
>> from which the MD5 intrinsic takes inspiration
On Sun, 20 Dec 2020 20:27:03 GMT, Claes Redestad wrote:
> - The MD5 intrinsics added by
> [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902) shows that
> the `int[] x` isn't actually needed. This also applies to the SHA intrinsics
> from which the MD5 intrinsic takes inspiration
>
On Fri, 15 Jan 2021 23:21:00 GMT, Valerie Peng wrote:
>> Claes Redestad has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 additional
>> commits
> - The MD5 intrinsics added by
> [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902) shows that
> the `int[] x` isn't actually needed. This also applies to the SHA intrinsics
> from which the MD5 intrinsic takes inspiration
> - Using VarHandles we can simplify the code in `ByteArray
On Fri, 15 Jan 2021 23:36:35 GMT, Claes Redestad wrote:
>> - The MD5 intrinsics added by
>> [JDK-8250902](https://bugs.openjdk.java.net/browse/JDK-8250902) shows that
>> the `int[] x` isn't actually needed. This also applies to the SHA intrinsics
>> from which the MD5 intrinsic takes inspirati
On Fri, 15 Jan 2021 01:59:07 GMT, Leo Jiang wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
>> line 518:
>>
>>> 516: doclet.footer_specified=\
>>> 517: The -footer option is no longer supported and will be ignored.\n\
>>> 518:
23 matches
Mail list logo
