Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v8]

2021-01-29 Thread Clive Verghese
> Redo for 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears > to not be fully fixed > > This also fixes JDK-8259516: Alerts sent by peer may not be received > correctly during TLS handshake Clive Verghese has updated the pull request with a new target base due to a merge or a

Re: RFR: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl [v6]

2021-01-29 Thread Clive Verghese
On Thu, 28 Jan 2021 19:04:29 GMT, Xue-Lei Andrew Fan wrote: >> Clive Verghese has updated the pull request with a new target base due to a >> merge or a rebase. > > src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java line 1702: > >> 1700: if (!conContext.isInboundClosed(

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Weijun Wang
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote: > This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.o

RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Weijun Wang
This fix covers both - [[macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) - [[macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) - Commit messages

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m

2021-01-29 Thread Erik Joelsson
On Fri, 18 Dec 2020 19:20:47 GMT, Weijun Wang wrote: > This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.o

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has up

Re: RFR: 8258915: Temporary buffer cleanup [v6]

2021-01-29 Thread Weijun Wang
> Clean up temporary byte array, char array, and keyspec around keys and > passwords. > > No new regression test. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: drbg only in patch2: unchanged: - Changes: - all

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 14:57:56 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >> libosxkrb5/SCDynamicStoreConfig.m](https://

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
On Fri, 29 Jan 2021 20:51:04 GMT, Phil Race wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> same behavior as before -- empty realm map > > make/modules/java.security.jgss/Lib.gmk line 84: > >> 82: $(cal

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 21:47:32 GMT, Weijun Wang wrote: >> src/java.base/macosx/native/libosxsecurity/KeystoreImpl.m line 619: >> >>> 617: (*env)->ReleaseCharArrayElements(env, passwordObj, >>> passwordChars, >>> 618: JNI_ABORT); >>> 619: } >> >> Although you h

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v2]

2021-01-29 Thread Weijun Wang
On Fri, 29 Jan 2021 22:05:21 GMT, Phil Race wrote: >> So I should remember how env was retrieved and only detach when it's from >> `AttachCurrentThreadAsDaemon`? In fact, in my test the plain `GetEnv` has >> never succeeded and it was always attached. > > Yes that is the idea. BTW which thread

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v3]

2021-01-29 Thread Weijun Wang
> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has up

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v3]

2021-01-29 Thread Phil Race
On Fri, 29 Jan 2021 22:47:52 GMT, Weijun Wang wrote: >> This fix covers both >> >> - [[macOS]: Remove JNF dependency from >> libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) >> - [[macOS]: Remove JNF dependency from >> libosxkrb5/SCDynamicStoreConfig.m](https://

RFR [17]: JDK-8260310 Release Note: Configurable extensions with system properties

2021-01-29 Thread Xue-Lei Fan
Hi, May I have the following release note reviewed: https://bugs.openjdk.java.net/browse/JDK-8260310 Thanks, Xuelei

Integrated: 8217633: Configurable extensions with system properties

2021-01-29 Thread Xue-Lei Andrew Fan
On Fri, 11 Dec 2020 23:20:34 GMT, Xue-Lei Andrew Fan wrote: > The TLS protocols are designed to tolerant unknown TLS extensions. However, > although it is not common, there are a few TLS implementations that cannot > handle unknown extensions properly. As results in unexpected interoperability

Re: RFR [17]: JDK-8260310 Release Note: Configurable extensions with system properties

2021-01-29 Thread Jamil Nimeh
Hi Xuelei, looks good overall, some minor suggestions only: * 1st paragraph: Change "...block extensions used in client side" and "...used to block extensions used in server side" to say "...used in the client." and "...used in the server." (you can remove the "side" words). * 1st para

Re: RFR [17]: JDK-8260310 Release Note: Configurable extensions with system properties

2021-01-29 Thread Xue-Lei Fan
Hi Jamil, All good catches! Thanks for the review. I updated accordingly. Xuelei On Jan 29, 2021, at 4:41 PM, Jamil Nimeh mailto:jamil.j.ni...@oracle.com>> wrote: Hi Xuelei, looks good overall, some minor suggestions only: * 1st paragraph: Change "...block extensions used in client sid