On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java/net and sun/net changes LGTM
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
There are a bunch of calls to `Collections.sort()` without a comparator
specified (at least in java.desktop):
https://github.com/openjdk/jdk/b
On Sun, 22 Aug 2021 23:02:06 GMT, Sergey Bylokhov wrote:
>> This is the continuation of JDK-8233884, JDK-8271456, and JDK-8272120.
>>
>> In many places standard charsets are looked up via their names, for example:
>> absolutePath.getBytes("UTF-8");
>>
>> This could be done more efficiently(up t
> This code change adds new methods to `DerInputStream` to easily and safely
> read optional fields in a ASN.1 DER-encoded value. It also adds several
> wrapping methods to `DerValue` to avoid unnecessary memory copying when
> calling by an internal method.
>
> The new methods are applied to `O
On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov
wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
java.time changes look good.
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5229
On Tue, 24 Aug 2021 14:24:00 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling by
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath wrote:
>> I would like to submit AES-GCM optimization for x86_64 architectures
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
On Mon, 23 Aug 2021 20:04:00 GMT, Anthony Scarpino
wrote:
>> Smita Kamath has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> changes to make sure that ghash_long_swap_mask and counter_mask_addr calls
>> are not duplicated
>
> Tier 1-3 pas
On Tue, 24 Aug 2021 14:24:00 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling by
On Tue, 24 Aug 2021 17:04:01 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/share/classes/sun/security/util/DerValue.jav
On Tue, 24 Aug 2021 17:04:01 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/share/classes/sun/security/util/DerValue.jav
On Tue, 24 Aug 2021 17:03:41 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/share/classes/sun/security/util/DerValue.jav
On Tue, 24 Aug 2021 14:24:00 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling by
On Tue, 24 Aug 2021 17:47:18 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> src/java.base/share/classes/sun/security/util/DerInputStre
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath wrote:
>> I would like to submit AES-GCM optimization for x86_64 architectures
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
On Fri, 14 May 2021 00:42:35 GMT, Smita Kamath wrote:
> I would like to submit AES-GCM optimization for x86_64 architectures
> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES
> and GHASH operations.
> Performance gain of ~1.5x - 2x for message sizes 8k and above.
Thi
On Tue, 24 Aug 2021 14:24:00 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling by
On Tue, 24 Aug 2021 19:06:37 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> best practice for reading DEFAULT, switch expression, etc
>
> test/jdk/com/sun/crypto/provider/AlgorithmParameters/OAEPO
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8272863: Replace usages of Collections.sort with List.sort call in public
java modules
On Tue, 24 Aug 2021 11:48:46 GMT, Alexander Zvegintsev
wrote:
> Is there any reason to not touch them along with this fix?
Update them too.
-
PR: https://git.openjdk.java.net/jdk/pull/5229
> This code change adds new methods to `DerInputStream` to easily and safely
> read optional fields in a ASN.1 DER-encoded value. It also adds several
> wrapping methods to `DerValue` to avoid unnecessary memory copying when
> calling by an internal method.
>
> The new methods are applied to `O
On Tue, 24 Aug 2021 22:15:52 GMT, Weijun Wang wrote:
>> This code change adds new methods to `DerInputStream` to easily and safely
>> read optional fields in a ASN.1 DER-encoded value. It also adds several
>> wrapping methods to `DerValue` to avoid unnecessary memory copying when
>> calling by
22 matches
Mail list logo
