Please review this small API enhancement to add the usual constructors taking a
cause to javax.net.ssl exceptions. The use of initCause in the JSSE
implementation code is updated to use the new constructors accordingly.
Please review the CSR: https://bugs.openjdk.java.net/browse/JDK-8282724
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
>
`List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when called
with vararg of size 0, 1, 2.
In general replacement of `Arrays.asList()` with `List.of()` is dubious as the
latter is null-hostile, however
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()`
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()`
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Mon, 7 Mar 2022 15:54:02 GMT, liach wrote:
> Notice list.of will have the downside of copying the input array when the
> size is not small while arrays aslist does not. Is the tradeoff worth it?
A good observation. In a couple of these places we could probably use
On Mon, 7 Mar 2022 13:40:48 GMT, Erik Joelsson wrote:
> > Should I change the JBS issue title to match the PR title, or is it
> > preferred for the PR title to change?
>
> They need to match. You can either do it manually, or change the title to
> just the bug number and the bot will change
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review the CSR:
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
What problem are you having editing the PR header? You should be able to do
so as the author of the PR
-
PR:
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review the CSR:
On Fri, 4 Mar 2022 21:17:01 GMT, Joe Darcy wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to SocketException and then update uses of initiCause on creating
> SocketException to instead pass the cause via the constructor.
>
> Please also review
On Fri, 4 Mar 2022 23:43:30 GMT, Bradford Wetmore wrote:
>> zzambers has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated copyright for SSLSocket.java
>
> There are more changes needed, and should probably be done as part of this
>
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
But as the JBS title and PR title now match, this is a moot point.
-
PR:
Hi Xuelei,
Please start this discussion in a new thread with a new subject (ex:
Proposal for potential new feature: TLS Certificate Compression) as it
should be evaluated on its own prior to reaching consensus and deciding
if a JEP should be drafted.
Also, keep in mind that it may take a
On Mon, 7 Mar 2022 17:55:45 GMT, Joe Darcy wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to SocketException and then update uses of initiCause on
>> creating SocketException to instead pass the cause via the constructor.
>>
>> Please also
On Mon, 7 Mar 2022 16:34:08 GMT, zzambers wrote:
> Sure if more changes are desired I can pull your changes. When It comes to
> CSR I am not fully familiar with the
process. Is action expected from my side?
One of us needs to get the CSR approved. Why don't you pull the changes
described
Hi,
We (zzambers/I) need a reviewer for this CSR involving the close
@apiNote of SSLSocket.java:
https://bugs.openjdk.java.net/browse/JDK-8282768
Fix API Note in javadoc for javax.net.ssl.SSLSocket
The original bug JDK-8282529[1] is/has been discussed in these threads
[2][3], and
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
Exactly. You should see an "Edit" button near the right edge of the PR title.
See the attached image:
On Mon, 7 Mar 2022 17:12:25 GMT, Magnus Ihse Bursie wrote:
> TheShermanTanker is not the author of this PR, he's just assisting the author
> by creating the JBS issue.
Ah, that explains it then.
-
PR: https://git.openjdk.java.net/jdk/pull/7268
On Fri, 4 Mar 2022 14:59:54 GMT, Sean Mullan wrote:
> Please review this change to fully support RFC 6125 in the TLS
> implementation. This change forbids wildcard domains in TLS certificates
> unless the wildcard is in the left-most component. Certificates of this
> nature should be rare and
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
> Please review the CSR:
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
Hi,
The TLS Certificate Compression standard was described in RFC 8879, and has
been enabled in browser Chrome and Safari. What’s TLS Certificate Compression
and what’s the benefits of this feature?
For TLS connections, a client must authenticate the identity of the server.
This typically
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
On Mon, 7 Mar 2022 07:52:29 GMT, Xue-Lei Andrew Fan wrote:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
>
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
>> Hi
>>
>> I have reviewed the code for removing double semicolons at the end of lines
>>
>> all the best
>> matteo
>
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
On Mon, 7 Mar 2022 21:26:34 GMT, Rajan Halade wrote:
>> Please review this change to fully support RFC 6125 in the TLS
>> implementation. This change forbids wildcard domains in TLS certificates
>> unless the wildcard is in the left-most component. Certificates of this
>> nature should be
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
This pull request has now been integrated.
Changeset: ccad3923
Author:Matteo Baccan
Committer: Magnus Ihse Bursie
URL:
On Thu, 3 Mar 2022 19:33:21 GMT, Andrey Turbanov wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
This pull request has now been integrated.
Changeset: 50eb915a
Author:Andrey Turbanov
URL:
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
Hi,
The TLS Certificate Compression standard was described in RFC 8879, and has
been enabled in browser Chrome and Safari. What’s TLS Certificate Compression
and what’s the benefits of this feature?
For TLS connections, a client must authenticate the identity of the server.
This typically
Thank you for the suggestion, Sean.
Hi all, please discuss the proposal in the new thread:
https://mail.openjdk.java.net/pipermail/security-dev/2022-March/029242.html
Xuelei
> On Mar 7, 2022, at 10:16 AM, Sean Mullan wrote:
>
> Hi Xuelei,
>
> Please start this discussion in a new thread
On Mon, 7 Mar 2022 20:39:44 GMT, Xue-Lei Andrew Fan wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java
>> line 158:
>>
>>> 156: } catch (GeneralSecurityException gse) {
>>> 157: throw new SSLHandshakeException(
>>> 158:
On Mon, 7 Mar 2022 20:30:07 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/SSLTrafficKeyDerivation.java
> line 158:
>
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
On Sat, 5 Mar 2022 06:49:43 GMT, Andrey Turbanov wrote:
>> Pass cause exception as constructor parameter is shorter and easier to read.
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8282632: Cleanup unnecessary calls
On Mon, 7 Mar 2022 20:36:41 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java line
> 263:
>
>>
On Mon, 7 Mar 2022 19:42:47 GMT, Xue-Lei Andrew Fan wrote:
>> Please review this small API enhancement to add the usual constructors
>> taking a cause to javax.net.ssl exceptions. The use of initCause in the
>> JSSE implementation code is updated to use the new constructors accordingly.
>>
On Mon, 7 Mar 2022 20:24:08 GMT, Rajan Halade wrote:
> Update following for SSLPeerUnverifiedException -
>
> https://github.com/openjdk/jdk/blob/master/src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java#L439
Hm, I will check more usage out of the JSSE implementation
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
> Please review the CSR:
On Mon, 7 Mar 2022 20:34:02 GMT, Bradford Wetmore wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typo correction
>
> src/java.base/share/classes/sun/security/ssl/ECDHKeyExchange.java line 204:
>
>> 202:
> Please review this small API enhancement to add the usual constructors taking
> a cause to javax.net.ssl exceptions. The use of initCause in the JSSE
> implementation code is updated to use the new constructors accordingly.
>
> Please review the CSR:
44 matches
Mail list logo
