Re: RFR: 8285404: RSA signature verification should follow RFC 8017 8.2.2 Step 4

2022-04-24 Thread Weijun Wang
On Fri, 22 Apr 2022 23:20:43 GMT, Valerie Peng wrote: > Regardless whether we ended up with decode/encode, we should make sure > RSASSA-PSS signature impl is also covered and consistent. RSASSA-PSS is not affected. Neither with the PKCS11 RSA signature. - PR: https://git.openjdk.j

Re: RFR: 8285389: EdDSA trimming zeros

2022-04-24 Thread Anthony Scarpino
On Sat, 23 Apr 2022 14:39:50 GMT, Xue-Lei Andrew Fan wrote: > Did you want to correct the verify testing so that it could > accept trimmed signature? Or do not trimming the extra zeros > of the signature any longer? I did not get the point from the > patch. The test is correct. Perhaps a clea

Re: RFR: 8285389: EdDSA trimming zeros

2022-04-24 Thread Xue-Lei Andrew Fan
On Sun, 24 Apr 2022 15:34:23 GMT, Anthony Scarpino wrote: > > Did you want to correct the verify testing so that it could > > accept trimmed signature? Or do not trimming the extra zeros > > of the signature any longer? I did not get the point from the > > patch. > > The test is correct. Perh

Re: RFR: 8285389: EdDSA trimming zeros

2022-04-24 Thread Xue-Lei Andrew Fan
On Fri, 22 Apr 2022 21:04:58 GMT, Anthony Scarpino wrote: > Hi, > > I'd like a code review of this change to EdDSA. ed25519 and ed448 internally > was trimming extra zeros off the end of the signature before processing. This > can result in some verify testing failures which are strict about

Re: RFR: 8285389: EdDSA trimming zeros

2022-04-24 Thread Anthony Scarpino
On Fri, 22 Apr 2022 21:04:58 GMT, Anthony Scarpino wrote: > Hi, > > I'd like a code review of this change to EdDSA. ed25519 and ed448 internally > was trimming extra zeros off the end of the signature before processing. This > can result in some verify testing failures which are strict about

Re: [Internet]JDK-8221218 - Insufficient buffer remaining for AEAD cipher fragment (2). Needs to be more than tag size (16)

2022-04-24 Thread xueleifan(XueleiFan)
Hi Thomas, Did you have a reproducing code that I would play with? Thanks, Xuelei On Apr 24, 2022, at 2:01 PM, Thomas Lußnig mailto:open...@suche.org>> wrote: Hi, i like to inform you that this problem is not yet fixed. I Use java 18.0.1 and the problem still popup. OS: Win 11 openjdk 18 20

JDK-8221218 is not yet fixed

2022-04-24 Thread xueleifan(XueleiFan)
Hi Thomas, Did you have reproducing code that I could play with? Thanks, Xuelei

Re: RFR: 8285389: EdDSA trimming zeros

2022-04-24 Thread Xue-Lei Andrew Fan
On Mon, 25 Apr 2022 05:22:33 GMT, xueleifan(XueleiFan) wrote: > Hi Thomas, > > Did you have a reproducing code that I would play with? > > Thanks, > Xuelei [mlbridge](https://github.com/apps/mlbridge) copied the comment, but it is not expected to post here. This PR is not related to JDK-8221

Re: RFR: 8284910: Buffer clean in PasswordCallback [v2]

2022-04-24 Thread Xue-Lei Andrew Fan
On Wed, 20 Apr 2022 19:30:11 GMT, Sean Mullan wrote: > However, I think that we need to carefully check the interactions between > cleaners and methods that explicitly allow the contents to be cleared so that > there are not unexpected results. I think @RogerRiggs explained the behavior of Cle

Re: RFR: 8284490: Remove finalizer method in java.security.jgss [v8]

2022-04-24 Thread Xue-Lei Andrew Fan
> Please review the update to remove finalizer method in the java.security.jgss > module. It is one of the efforts to clean up the use of finalizer method in > JDK. Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 1

Re: RFR: 8285398: Cache the results of constraint checks

2022-04-24 Thread Daniel Jeliński
On Sat, 23 Apr 2022 14:57:01 GMT, Xue-Lei Andrew Fan wrote: >> Profiling the TLS handshakes using SSLHandshake benchmark shows that a large >> portion of time is spent in HandshakeContext initialization, specifically in >> DisabledAlgorithmConstraints class. >> >> There are only a few instance