Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v5]

2022-06-09 Thread Sibabrata Sahoo
> A Test updated to cover the getCodeSigners. Sibabrata Sahoo has updated the pull request incrementally with two additional commits since the last revision: - 8209935: Test to cover CodeSource.getCodeSigners() - 8209935: Test to cover CodeSource.getCodeSigners() - Changes: -

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sibabrata Sahoo
On Thu, 9 Jun 2022 21:12:26 GMT, Sean Mullan wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8209935: Test to cover CodeSource.getCodeSigners() > > test/jdk/java/security/CodeSource/CertsMatch.java line 27: >

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Weijun Wang
On Thu, 9 Jun 2022 22:29:36 GMT, Jamil Nimeh wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> verb > > src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java line > 161: > >> 159: // This

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Jamil Nimeh
On Thu, 9 Jun 2022 23:10:05 GMT, Weijun Wang wrote: >> Add comment to the method. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > verb Thanks, LGTM. - Marked as reviewed by jnimeh (Reviewer). PR:

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0 [v2]

2022-06-09 Thread Weijun Wang
> Add comment to the method. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: verb - Changes: - all: https://git.openjdk.org/jdk/pull/9115/files - new: https://git.openjdk.org/jdk/pull/9115/files/36741bba..15ef85fe

Re: RFR: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' [v2]

2022-06-09 Thread Hai-May Chao
On Thu, 9 Jun 2022 21:00:55 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Inconsistent entries test >> - Inconsistent entries test > >

Re: RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

2022-06-09 Thread Jamil Nimeh
On Thu, 9 Jun 2022 21:34:56 GMT, Weijun Wang wrote: > Add comment to the method. src/java.base/share/classes/sun/security/util/math/IntegerModuloP.java line 161: > 159: // This method is used in 2 cases: > 160: // 1. To calculate the inverse of a number in ECDSAOperations, >

RFR: 8287178: IntegerModuloP::multiplicativeInverse returns 0 for 0

2022-06-09 Thread Weijun Wang
Add comment to the method. - Commit messages: - add comment Changes: https://git.openjdk.org/jdk/pull/9115/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9115=00 Issue: https://bugs.openjdk.org/browse/JDK-8287178 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod

Re: RFR: 8209935: Test to cover CodeSource.getCodeSigners() [v4]

2022-06-09 Thread Sean Mullan
On Wed, 8 Jun 2022 10:30:45 GMT, Sibabrata Sahoo wrote: >> A Test updated to cover the getCodeSigners. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > 8209935: Test to cover CodeSource.getCodeSigners() Marked as

Re: RFR: 8286779: javax.crypto.CryptoPolicyParser#isConsistent always returns 'true' [v2]

2022-06-09 Thread Sean Mullan
On Tue, 7 Jun 2022 20:52:33 GMT, Hai-May Chao wrote: >> Please review a small fix in CryptoPolicyParser class that it should not >> pass “processedPermissions” parameter by value. >> Ran MACH5 tier1 and tier2 without failures. > > Hai-May Chao has updated the pull request incrementally with two

RFR: 8271838: AmazonCA.java interop test fails

2022-06-09 Thread Rajan Halade
Updated test certificates to new from CA. I did a loop run of this test and don't see the intermittent failure anymore. - Commit messages: - 8271838: AmazonCA.java interop test fails Changes: https://git.openjdk.org/jdk/pull/9111/files Webrev:

Re: RFR: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions [v2]

2022-06-09 Thread Bradford Wetmore
On Thu, 2 Jun 2022 21:02:16 GMT, Daniel Jeliński wrote: >> Session ticket extension should only contain pre-TLS1.3 stateless session >> tickets; it should not be used for sending TLS1.3 pre-shared keys. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit

RFR: 8288132: Update test artifacts in QuoVadis CA interop tests

2022-06-09 Thread Rajan Halade
Updated test artifacts. Test will continue to fail intermittently with what appears to be issue in CA infra. JDK-8277855 will track it. - Commit messages: - 8288132: Update test artifacts in QuoVadis CA interop tests Changes: https://git.openjdk.org/jdk/pull/9110/files Webrev: