Changeset: 4ec7d1890538
Author:lancea
Date: 2009-08-20 19:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ec7d1890538
6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make
constants final that needed to be. (also reviewed by ksaks, ryano)
Reviewed-by:
Changeset: 3e239fe92832
Author:lancea
Date: 2010-08-10 10:07 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e239fe92832
6898593: java.sql.Date.valueOf no exception if date given is not in the JDBC
date escape syntax
Reviewed-by: minqi
!
Changeset: 1f99ad63eb9e
Author:lancea
Date: 2010-09-04 12:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f99ad63eb9e
6861385: Updated SQLException subclasses to clarify that they may be thrown for
vendor specific conditions
Reviewed-by: alanb
!
Changeset: c786a9c927fd
Author:lancea
Date: 2010-09-10 15:26 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c786a9c927fd
6589685: JDBC 4.1 updates
Reviewed-by: darcy
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
!
Changeset: 73872b992aab
Author:lancea
Date: 2010-09-10 18:51 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73872b992aab
6983984: Fixed typo in DatabaseMetaData.getPseudoColumns() javadocs
Reviewed-by: darcy
! src/share/classes/java/sql/DatabaseMetaData.java
Changeset: 7794d718ffe2
Author:lancea
Date: 2010-09-17 13:23 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7794d718ffe2
6983452: SyncProvider issue for JoinRowSet implementation
Reviewed-by: darcy, ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset:
Changeset: 9a8022905f6a
Author:lancea
Date: 2010-10-01 14:36 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a
6988993: Address Findbugs warnings for the use of String Constructor
Reviewed-by: ohair
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
!
Changeset: 0f23a139e819
Author:lancea
Date: 2010-10-06 10:09 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819
6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security
permission
Reviewed-by: darcy
!
Changeset: af2de4de1076
Author:lancea
Date: 2010-11-12 07:15 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/af2de4de1076
6982530: javadoc update to SyncFactory JdbcResource bundle for
synchronization issues
Reviewed-by: alanb
!
Changeset: c4a38022fdc1
Author:lancea
Date: 2010-11-12 08:41 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4a38022fdc1
6999086: Clarify that SyncFactory.setLogger can throw an NullPointerException
Reviewed-by: alanb
!
Changeset: ff619988afac
Author:lancea
Date: 2010-11-19 17:15 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff619988afac
7000752: Duplicate entry in RowSetResourceBundles.properties
Reviewed-by: alanb
! src/share/classes/com/sun/rowset/RowSetResourceBundle.properties
!
Changeset: 1bf378034d39
Author:lancea
Date: 2010-12-09 13:01 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bf378034d39
6659234: Incorrect check in SerialBlob.getBytes
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/serial/SerialBlob.java
Changeset: a72e7147816f
Author:lancea
Date: 2010-12-14 16:08 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a72e7147816f
7006454: Typo in javadocs typo for Statement.executeBatch @since
Reviewed-by: alanb
! src/share/classes/java/sql/Statement.java
Changeset: f4d755bbdabe
Author:lancea
Date: 2011-01-10 14:43 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4d755bbdabe
6544224: Remove the need of sun.reflect.misc
Reviewed-by: alanb
! src/share/classes/javax/sql/rowset/serial/SerialJavaObject.java
Changeset: befe813e24d2
Author:lancea
Date: 2011-01-11 12:36 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/befe813e24d2
7000693: java.sql.Timestamp compareTo() issues using low values
Reviewed-by: okutsu
! src/share/classes/java/sql/Timestamp.java
Changeset: 9599534b1727
Author:lancea
Date: 2011-02-04 09:07 -0500
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9599534b1727
7014095: Broken link in java.sql package specification
Reviewed-by: alanb
! src/share/classes/java/sql/package.html
Changeset: df9991dc1f0d
Author:lancea
Date: 2011-03-17 11:37 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df9991dc1f0d
7026898: DriverManager to now use CopyOnWriteArrayList
Reviewed-by: alanb, briangoetz
! src/share/classes/java/sql/DriverManager.java
Changeset: d5bc10b1aa2c
Author:lancea
Date: 2011-04-06 17:37 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5bc10b1aa2c
7034471: Wrap registeredDrivers in DriverManager
Reviewed-by: alanb, briangoetz
! src/share/classes/java/sql/DriverManager.java
Changeset: 5137806a3e34
Author:lancea
Date: 2011-04-07 11:25 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34
7034656: Address lint warnings for DriverManager
Reviewed-by: alanb, forax, ohair
! src/share/classes/java/sql/DriverManager.java
Changeset: 1bb95f6ac753
Author:lancea
Date: 2011-04-12 12:25 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753
7035615: Address lint warnings for javax.sql.rowset com.sun.rowset
Reviewed-by: alanb, darcy
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
!
Changeset: 0bae251b548b
Author:lancea
Date: 2011-04-12 14:32 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b
7007772: Address typos in javadoc for ResultSet
Reviewed-by: ohair, smarks
! src/share/classes/java/sql/ResultSet.java
Changeset: d9248245a88c
Author:lancea
Date: 2011-04-13 11:21 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9248245a88c
7036251: Correct SQLPermission constructor javadocs for permission target names
Reviewed-by: alanb
! src/share/classes/java/sql/SQLPermission.java
Changeset: 28caa191884a
Author:lancea
Date: 2011-04-28 09:46 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/28caa191884a
7038565: address Findbugs issue in BatchUpdateException
Reviewed-by: alanb, forax
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 0b1354ecf5a3
Author:lancea
Date: 2011-04-29 09:04 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b1354ecf5a3
7040150: Indexing Error in CachedRowSetImpl.removeCurrentRow
Reviewed-by: smarks
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
Changeset: 6a3a41e0af88
Author:lancea
Date: 2011-05-10 14:41 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a3a41e0af88
7043443: address missed reason initialization in BatchUpdateException
Reviewed-by: alanb
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: a00f48c96345
Author:lancea
Date: 2011-06-02 12:02 -0400
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a00f48c96345
7049107: Cannot call initCause() on BatchUpdateException
Reviewed-by: darcy
! src/share/classes/java/sql/BatchUpdateException.java
Changeset: 7676670d1e97
Author:lancea
Date: 2011-08-10 16:23 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97
7077451: SerialLob, SerialClob have the wrong checks for setStream methods
Reviewed-by: alanb
Contributed-by: Patrick Reinhart patr...@reini.net
!
Changeset: 3c524deb8431
Author:lancea
Date: 2011-12-02 19:33 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c524deb8431
7116445: Miscellaneous warnings in the JDBC/RowSet classes
Reviewed-by: smarks, chegar
! src/share/classes/com/sun/rowset/CachedRowSetImpl.java
!
Changeset: 303b67074666
Author:lancea
Date: 2012-01-24 15:13 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/303b67074666
7132879: address Findbugs issue in WebRowSetXmlWriter
Reviewed-by: forax
! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java
Changeset: b518b160607f
Author:lancea
Date: 2012-01-26 19:41 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b518b160607f
7133815: address the findbug errors in CachedRowSetImpl, SerialStruct,
BaseRow, SerialInputImpl, SerialOutputImpl
Reviewed-by: forax
!
Changeset: 4580652d9828
Author:lancea
Date: 2012-05-04 16:00 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828
7166598: FilteredRowSetImpl can result in Invalid Cursor Position
Reviewed-by: lancea
Contributed-by: Knut Anders Hatlen knut.hat...@oracle.com
!
Changeset: 6b6a73e8c036
Author:lancea
Date: 2012-06-12 17:32 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b6a73e8c036
7171918: XmlReaderContentHandler.endElement does not handle a Delete Tag
properly
Reviewed-by: joehw
!
Changeset: 11bfec75d333
Author:lancea
Date: 2012-08-30 13:38 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333
7193683: DriverManager Iterator Warning cleanup
Reviewed-by: lancea
Contributed-by: Dan Xu dan...@oracle.com
!
Changeset: 8c6895afe204
Author:lancea
Date: 2012-09-06 13:16 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c6895afe204
7192302: Remove JDBCRowSetImpl dependency on java.beans
Reviewed-by: alanb, mchung
! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java
Changeset: 036c55976cef
Author:lancea
Date: 2012-10-09 08:58 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef
7197395: Add @Deprecated to all deprecated methods to eliminate compiler
warnings in JDBC
Reviewed-by: alanb, smarks
!
Changeset: 3c4be36de073
Author:lancea
Date: 2012-10-10 11:15 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073
8000687: Correct javadoc typo for getLogWriter and setLogWriter
Reviewed-by: alanb
! src/share/classes/java/sql/DriverManager.java
Changeset: 734ca9f4719c
Author:lancea
Date: 2012-10-10 17:34 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c
8000712: Remove unused fields in SyncFactory
Reviewed-by: mchung
! src/share/classes/javax/sql/rowset/spi/SyncFactory.java
Changeset: 8748331f63cf
Author:lancea
Date: 2012-11-01 17:35 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8748331f63cf
8001536: Added readObject,writeObject,clone, equals, hashcode to SerialXLob
Reviewed-by: alanb, forax
!
Changeset: 78514544980d
Author:lancea
Date: 2013-01-19 10:11 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/78514544980d
8006139: add missing methods to javax.sql.rowset.serial.SQLInputImpl,
SQLOutputImpl
Reviewed-by: naoto, ulfzibis, alanb
!
Changeset: d3da0d29d7cd
Author:lancea
Date: 2013-01-19 10:53 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3da0d29d7cd
8005080: JDBC 4.2 Core changes
Reviewed-by: naoto
! src/share/classes/java/sql/BatchUpdateException.java
!
Changeset: de30e46250c5
Author:lancea
Date: 2013-01-21 14:08 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de30e46250c5
8006642: Fix javadoc warnings due to Integer.MAX_VALUE
Reviewed-by: alanb
! src/share/classes/java/sql/BatchUpdateException.java
!
Changeset: 1574fa3df1c0
Author:lancea
Date: 2013-02-06 14:15 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1574fa3df1c0
8006505: additional changes for JSR 310 support
Reviewed-by: naoto, ulfzibis
! src/share/classes/java/sql/JDBCType.java
!
Changeset: 9f9dac5a9e74
Author:lancea
Date: 2013-02-22 09:29 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f9dac5a9e74
8008716: address typo in CallableStatement javadocs
Reviewed-by: chegar
! src/share/classes/java/sql/CallableStatement.java
Changeset: 8d8a35ac7d40
Changeset: b456f25c2075
Author:lancea
Date: 2013-04-23 11:17 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075
8011620: adding free form netbeans project for jdbc to jdk/make/netbeans
Reviewed-by: chegar
! make/netbeans/common/shared.xml
+
Changeset: ac3e189c9099
Author:lancea
Date: 2013-04-30 14:44 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac3e189c9099
8010416: Add a way for java.sql.Driver to be notified when it is deregistered
Reviewed-by: alanb, ulfzibis
! src/share/classes/java/sql/Driver.java
+
Changeset: e2333bd8514a
Author:lancea
Date: 2013-06-07 14:13 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2333bd8514a
8016101: Fix typo in SerialRef and missing @param in SerialStruct
Reviewed-by: darcy
! src/share/classes/javax/sql/rowset/serial/SerialRef.java
!
Changeset: b9ba04dc210f
Author:lancea
Date: 2013-06-27 15:07 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9ba04dc210f
8017471: Fix JDBC -Xdoclint public errors
Reviewed-by: darcy
! src/share/classes/java/sql/Blob.java
! src/share/classes/java/sql/CallableStatement.java
!
Changeset: a4eb59bffb60
Author:lancea
Date: 2013-06-29 06:12 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a4eb59bffb60
8019286: Fix javadoc typo in ResultSet.next
Reviewed-by: darcy, mchung
! src/share/classes/java/sql/ResultSet.java
Changeset: cc64a05836a7
Author:lancea
Date: 2013-08-12 16:09 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc64a05836a7
8022753: SQLXML javadoc example typo
Reviewed-by: alanb, mchung
! src/share/classes/java/sql/SQLXML.java
Changeset: 60d6f60416ca
Author:lancea
Date: 2013-09-12 13:20 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60d6f60416ca
8015340: remove erroneous @since tag
Reviewed-by: darcy
! src/share/classes/java/sql/PreparedStatement.java
Changeset: 5c7690923663
Author:lancea
Date: 2013-09-13 19:10 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c7690923663
8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver
is null
Reviewed-by: alanb
!
Changeset: 657482758408
Author:lancea
Date: 2013-09-17 07:56 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/657482758408
7097386: Correct error in Predicate javadoc example
Reviewed-by: alanb, shade
! src/share/classes/javax/sql/rowset/Predicate.java
Changeset: 64c0ac7cd936
Author:lancea
Date: 2013-10-17 15:14 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/64c0ac7cd936
8026812: doclint clean up for java.sql and javax.sql
Reviewed-by: mduigou
! src/share/classes/java/sql/CallableStatement.java
!
Changeset: bcf5fa5e9509
Author:lancea
Date: 2013-12-02 16:06 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bcf5fa5e9509
8029417: JDBC 4.2 javadoc updates
Reviewed-by: darcy
! src/share/classes/java/sql/CallableStatement.java
! src/share/classes/java/sql/DriverManager.java
multiple classes in the jdk9-dev repo (except client
packages).
webrev: http://cr.openjdk.java.net/~rriggs/webrev-8044461-cleanup/
Issue: https://bugs.openjdk.java.net/browse/JDK-8044461
Thanks, Roger
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java
alexander.v.stepa...@oracle.com wrote:
Hello,
Could you please review the fix
http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/
for
https://bugs.openjdk.java.net/browse/JDK-8081517
Just some cleanup for docs.
Thanks,
Alexander
Lance Andersen| Principal Member of Technical Staff
tools/jarsigner/multiRelease/MVJarSigningTest.java
> Fri Feb 03 11:18:23 2017 -0800
> @@ -74,7 +74,8 @@
> private static final String KEYPASS = "changeit";
> private static final String SIGNED_JAR = "Signed.jar";
> private static final String POLICY_FIL
*
> * manageProcess
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.g
://bugs.openjdk.java.net/browse/JDK-8184208
> Webrev: http://cr.openjdk.java.net/~jjg/8184208/webrev.00/
> API: http://cr.openjdk.java.net/~jjg/8184208/api.00/
>
> -- Jon
>
>
>
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/u
/webrev-line-separator-8198645/
>
> Thanks, Roger
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/o
;
> /** indicate compatibility with JDK 1.1.x version of class. */
> +@SuppressWarnings("serial") // serialVersionUID in an interface is
> ineffectual
> static final long serialVersionUID = 3632638527362204081L;
>
> /**
> --- old/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06
> 12:04:54.494000999 -0700
> +++ new/src/java.rmi/share/classes/java/rmi/server/ServerRef.java 2018-08-06
> 12:04:54.338000999 -0700
> @@ -39,6 +39,7 @@
> public interface ServerRef extends RemoteRef {
>
> /** indicate compatibility with JDK 1.1.x version of class. */
> +@SuppressWarnings("serial") // serialVersionUID in an interface is
> ineffectual
> static final long serialVersionUID = -4557750989390278438L;
>
> /**
>
>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
s/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
ave to resort to
>>>> throwing an IOE?
>>>>
>>> Maybe although it would be a bit awkward to deal with. The issues around
>>> this remind me a bit about mounting fat32 file systems on Linux or Unix
>>> systems where the fields in the stat structure are populated with
>>> default values. PosixFileAttributeView::readAttributes is essentially
>>> the equivalent of a stat call. This might be something to look at for
>>> the file owner at least.
>>>
>>> -Alan
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
T ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> *
> * This code is free software; you can redistribute it and/or modify it
>
> -Chris.
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<ht
see http://openjdk.java.net/jtreg/tag-spec.html for the system
properties. I do not see test.dir there.
—
I would just do:
—
Path foo = Path.of("test.zip");
System.out.println("test.zip path=" + foo.toAbsolutePath());
--
which results in the
quot;zip:permissions" and we'll document this. If a user of zipfs wants
>> to see full PosixFileAttributeView support with default values, then we
>> should allow for a creation attribute for the zipfs that can control this.
>> Maybe
>> we can even allow specifying default values for user, group and permissions
>> via zipfs attributes.
>>
>> I'll work to develop the patch into this direction unless you tell me that
>> this
>> idea is bogus (if so, then I hope it be soon )
>>
>> Thanks
>> Christoph
>>
>>
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
e.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781
On Mon, 7 Sep 2020 18:57:11 GMT, Sean Coffey wrote:
>> Continuation of RFR thread from
>> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>>
>> CSR has been approved.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the
On Tue, 15 Sep 2020 16:59:59 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove "final"
>
> I am fine with this as well. I will pull over the chan
On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote:
> Continuation of RFR thread from
> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html
>
> CSR has been approved.
I think this looks good over all Sean. In your SymLinkTest, I probably would
have the test delete
On Tue, 6 Oct 2020 10:02:09 GMT, Volker Simonis wrote:
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a
On Wed, 7 Oct 2020 16:43:53 GMT, Volker Simonis wrote:
>> Alan makes a good point. Perhaps we keep things simple and focus solely on
>> tweaking the description of the change in
>> behavior which is described in your last paragraph
>
> I totally agree. What about using just the last sentence
On Tue, 6 Oct 2020 10:02:09 GMT, Volker Simonis wrote:
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a
On Wed, 7 Oct 2020 15:10:06 GMT, Alan Bateman wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write a
On Tue, 6 Oct 2020 10:02:09 GMT, Volker Simonis wrote:
> ### Summary
>
> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
> which can lead to the `ZipException "invalid
> entry compressed size"`.
> ### Motivation
>
> In general it is not safe to directly write a
On Tue, 13 Oct 2020 11:40:36 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Tue, 13 Oct 2020 18:46:59 GMT, Alan Bateman wrote:
>> Volker Simonis has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now
>> contains one commit:
>> 8253952: Refine ZipOutputStream.putNextEntry() to recalculate ZipEntry's
>> compressed
On Wed, 7 Oct 2020 17:04:02 GMT, Lance Andersen wrote:
>> I totally agree. What about using just the last sentence (as you've
>> proposed) in the spec section and add the other to
>> as @implNote? O you think the last sentence will be enough?
>
> I think we can just g
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Tue, 13 Oct 2020 19:07:33 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Sun, 11 Oct 2020 17:22:58 GMT, Alan Bateman wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
>
On Mon, 12 Oct 2020 12:48:36 GMT, Alan Bateman wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR. The
>> pull request contains one new
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 11:44:28 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 15:49:29 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/util/jar/JarOutputStream.java line 81:
>>
>>> 79: * any previous entry. The default compression method will be
>>> 80: * used if no compression method was specified for the entry.
>>> 81: *
On Fri, 9 Oct 2020 10:28:34 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Wed, 14 Oct 2020 10:54:30 GMT, Volker Simonis wrote:
>> ### Summary
>>
>> Work around wrong usage of `ZipOutputStream.putNextEntry()` in user code
>> which can lead to the `ZipException "invalid
>> entry compressed size"`.
>> ### Motivation
>>
>> In general it is not safe to directly write
On Mon, 12 Oct 2020 11:46:31 GMT, Volker Simonis wrote:
>> I don't believe we discuss/reference the data descriptor for a Zip entry
>> (outside of the PKWare Zip specification) so I
>> am not sure we should reference it in the javadoc.
>> Placing the sentence after "The default compression
On Wed, 14 Oct 2020 14:52:29 GMT, Lance Andersen wrote:
>> Volker Simonis has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental
>> views will show differences compared to the previous content of the PR.
>
> The chang
On Thu, 1 Oct 2020 14:42:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review and a sponsor for a fix for
>> https://bugs.openjdk.java.net/browse/JDK-8242882?
>>
>> As noted in that JBS issue, if the size of the Manifest entry in the jar
>> happens to be very large (such that it exceeds
rds,
>>>>> Sean.
>>>>>
>>>>> On 26/08/2020 23:15, Weijun Wang wrote:
>>>>>> Are you going to update the warning text or create a new one?
>>>>>>
>>>>>> Thanks,
>>>>>> Max
>>>&g
On Wed, 30 Sep 2020 17:26:18 GMT, Brent Christian wrote:
>> test/jdk/java/util/jar/JarFile/LargeManifestOOMTest.java line 60:
>>
>>> 58: final OutOfMemoryError oome =
>>> Assert.expectThrows(OutOfMemoryError.class, () -> jar.getManifest());
>>> 59: // additionally verify that
me other means, or even
>> that the warning is because they are using unsigned values.
>>
>> It might be better to tweak the second part to make it a bit clearer, up to
>> you but something like "These attributes are ignored when signing and are
>> not protected by the signature".
>>
>> -Alan
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
v/>
> regards,
> Sean.
>
> On 12/06/2020 17:05, Lance Andersen wrote:
>> Hi Sean,
>>
>> I think your changes look fine so all good FMPOV.
>>
>> Best
>> Lance
>>
>>> On Jun 12, 2020, at 6:21 AM, Seán Coffey >> <mailto:sean.
security-dev/2020-January/021141.html
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>La
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1299
On Thu, 19 Nov 2020 17:08:21 GMT, Alan Bateman wrote:
>> Small change to retrieve the raw bytes of manifest during verifying signed
>> JAR.
>
> Marked as reviewed by alanb (Reviewer).
I can sponsor once you integrate
-
PR: https://git.openjdk.java.net/jdk/pull/1299
On Wed, 18 Nov 2020 21:59:01 GMT, Hai-May Chao wrote:
> Small change to retrieve the raw bytes of manifest during verifying signed
> JAR.
The changes looks good. I am assuming that we do not need an additional test
for this and if so, please add a noreg label such as noreg-trivial to the bug
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
looks fine
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
1 - 100 of 169 matches
Mail list logo
