HI Sean, I think the change looks reasonable and I would keep it focused on its current intent for zip files given the problem you were addressing.
The test also looks reasonable. Did you give any consideration to throwing a SkippedException if posixAttributes are not supported? Also remember to update your copyright year prior to pushing… Best Lance > On Jan 17, 2020, at 5:59 AM, Seán Coffey <sean.cof...@oracle.com> wrote: > > Hi, > > Looking to introduce some JDK private functionality which will help preserve > internal zip file attribute permissions when jarsigner is run on a zip file. > Some of the logic is taken from the recent work carried out in this area for > zipfs API. > > https://bugs.openjdk.java.net/browse/JDK-8218021 > http://cr.openjdk.java.net/~coffeys/webrev.8218021/webrev/ > > regards, > Sean. > > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
