Re: RFR: 8284105: Update security libraries to use sealed classes [v3]

2022-04-11 Thread Sean Mullan
> Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have subclasses were simply marked final instead of sealed.

Re: RFR: 8284105: Update security libraries to use sealed classes [v2]

2022-04-08 Thread Weijun Wang
On Fri, 8 Apr 2022 20:07:32 GMT, Sean Mullan wrote: >> Please review these changes to update the security libraries to use sealed >> classes. See JEP 409 for more details on sealed classes. >> >> No CSR is required as all the changes are to internal classes. A few classes >> that did not have

Re: RFR: 8284105: Update security libraries to use sealed classes [v2]

2022-04-08 Thread Sean Mullan
> Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have subclasses were simply marked final instead of sealed.

Re: RFR: 8284105: Update security libraries to use sealed classes [v2]

2022-04-08 Thread Sean Mullan
On Fri, 8 Apr 2022 16:11:27 GMT, Weijun Wang wrote: >> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make some classes package-private instead of sealed. > > src/java.base/share/classes/sun/security/rsa/RSASignature.java

Re: RFR: 8284105: Update security libraries to use sealed classes

2022-04-08 Thread Sean Mullan
On Fri, 8 Apr 2022 16:17:19 GMT, Weijun Wang wrote: > It looks `KrbTgsRep.java`, `Krb5ProxyCredential.java`, `Builder.java`, > `Vertex.java`, `Validator.java`, and `RSAKeyPairGenerator.java` can all be > made package private. Good point, although I would prefer to leave `Validator` as public

Re: RFR: 8284105: Update security libraries to use sealed classes

2022-04-08 Thread Xue-Lei Andrew Fan
On Fri, 8 Apr 2022 13:40:37 GMT, Sean Mullan wrote: > Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have

Re: RFR: 8284105: Update security libraries to use sealed classes

2022-04-08 Thread Weijun Wang
On Fri, 8 Apr 2022 13:40:37 GMT, Sean Mullan wrote: > Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have

Re: RFR: 8284105: Update security libraries to use sealed classes

2022-04-08 Thread Joe Darcy
On Fri, 8 Apr 2022 13:40:37 GMT, Sean Mullan wrote: > Please review these changes to update the security libraries to use sealed > classes. See JEP 409 for more details on sealed classes. > > No CSR is required as all the changes are to internal classes. A few classes > that did not have

RFR: 8284105: Update security libraries to use sealed classes

2022-04-08 Thread Sean Mullan
Please review these changes to update the security libraries to use sealed classes. See JEP 409 for more details on sealed classes. No CSR is required as all the changes are to internal classes. A few classes that did not have subclasses were simply marked final instead of sealed.