Re: RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

2020-03-25 Thread sha . jiang
Hi Rajan, Thanks for your suggestions. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8237977/webrev.01/ On 2020/3/25 11:08, Rajan Halade wrote: Hi John, Thanks for taking care of this fix. Your changes look good me. I have couple of suggestions: - consider changing he

Re: RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

2020-03-25 Thread Rajan Halade
Thanks for the update. Changes look good to me. - Rajan > On Mar 25, 2020, at 1:48 AM, sha.ji...@oracle.com wrote: > > Hi Rajan, > Thanks for your suggestions. > Please review the updated webrev: > http://cr.openjdk.java.net/~jjiang/8237977/webrev.01/ >

[RFR:15] Release Note: Disable native SunEC implementation by default

2020-03-25 Thread Anthony Scarpino
Please review the proposed release note for JDK-8237219, the change to disable the native curves in SunEC. https://bugs.openjdk.java.net/browse/JDK-8241386 Thanks Tony

Re: [RFR:15] Release Note: Disable native SunEC implementation by default

2020-03-25 Thread Jamil Nimeh
Hi Tony, * "Commonly used and time-constantly implemented curves, secp256r1, secp384r1, secp521r1, x25519, and x448, remain supported by SunEC" - time-constantly implemented sounds a bit awkward to my ear. o May I suggest an alternative: "The secp256r1, secp384r1, secp521r1, x2

Re: [RFR:15] Release Note: Disable native SunEC implementation by default

2020-03-25 Thread Anthony Scarpino
On 3/25/20 5:42 PM, Jamil Nimeh wrote: Hi Tony, * "Commonly used and time-constantly implemented curves, secp256r1, secp384r1, secp521r1, x25519, and x448, remain supported by SunEC" - time-constantly implemented sounds a bit awkward to my ear. o May I suggest an alternative: "Th