Hi Valerie,
I thought about random data again. I agree that it doesn't make much
difference if random data is used instead of static one. And as a
result, in this case 'randomness' key may be confusing (someone may want
to filter out tests which use random data for some reason).
I updated
Updated webrev looks good~
Valerie
On 7/24/2015 3:15 AM, Artem Smotrakov wrote:
Hi Valerie,
I thought about random data again. I agree that it doesn't make much
difference if random data is used instead of static one. And as a
result, in this case 'randomness' key may be confusing (someone
Hi Valerie,
The tests can easily get data in one line with RandomFacroty. But they
can use static data that may be created with something like the following:
public class Helper {
public static byte[] generateBytes(int length) {
byte[] bytes = new byte[length];
Hi Artem,
Just some nit (see below). In general, I find the tests don't need to
use so many random bytes. If we don't need RandomFactory, then no
dependence on jdk.testlibrary. Make things easier to execute the test on
its own if necessary. Just something to keep in mind for future test
