Hello,
If you don't mind, I moved some common code from SSLSocketTemplate.java
to SSLTest.java, so that it can be re-used by other tests. It may help
to avoid duplicate code.
http://cr.openjdk.java.net/~asmotrak/8164591/webrev.01/
Please take a look.
Artem
On 09/15/2016 11:49 AM, Artem Sm
Hi Xuelei, Chris,
Thank you for looking into it. Please see inline.
On 09/15/2016 12:53 AM, Chris Hegarty wrote:
On 15 Sep 2016, at 02:55, Xuelei Fan wrote:
On 9/15/2016 9:45 AM, Artem Smotrakov wrote:
Well, in this particular case it's not clear that it has the same issue
with free port (a
On 15/09/16 08:53, Chris Hegarty wrote:
Anyway, as a free port is used, there are free-port issues. Please consider to
make the enhancement in the fix. Otherwise, you cannot avoid the intermittent
failure for this test case in the current testing environment.
+1. Please remove any use of t
On 15 Sep 2016, at 02:55, Xuelei Fan wrote:
>
> On 9/15/2016 9:45 AM, Artem Smotrakov wrote:
>> Well, in this particular case it's not clear that it has the same issue
>> with free port (at least to me). The exception occurred on client side,
>> so it's not the case where we don't know where the
On 9/15/2016 9:45 AM, Artem Smotrakov wrote:
Well, in this particular case it's not clear that it has the same issue
with free port (at least to me). The exception occurred on client side,
so it's not the case where we don't know where the handshake came from.
;-) Yeh, you catch the point. But
Well, in this particular case it's not clear that it has the same issue
with free port (at least to me). The exception occurred on client side,
so it's not the case where we don't know where the handshake came from.
I can make this enhancement, but like I said I don't think it's going to
help,
On 9/15/2016 9:23 AM, Artem Smotrakov wrote:
Hi Xuelei,
For this one, I am not sure that it would help here since the test
failed after it already had started handshaking.
It has the same issue as a free-port is used. We don't actually know
the handshake is coming from the right client.
Xuel
Hi Xuelei,
For this one, I am not sure that it would help here since the test
failed after it already had started handshaking. I would prefer to have
it as a separate enhancement.
Artem
On 09/14/2016 06:19 PM, Xuelei Fan wrote:
As you were already there, I would suggest to consider the
SSL
As you were already there, I would suggest to consider the
SSLSocketSample.java template as the comment in JDK-8163924 review thread.
Thanks,
Xuelei
On 9/15/2016 9:13 AM, Artem Smotrakov wrote:
Not urgent, but I would appreciate if someone can get a chance to look
at this.
Artem
On 09/07/20
Not urgent, but I would appreciate if someone can get a chance to look
at this.
Artem
On 09/07/2016 03:17 PM, Artem Smotrakov wrote:
Sending to net-...@openjdk.java.net as well.
Artem
On 09/07/2016 12:28 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch for
sun/net/www
Sending to net-...@openjdk.java.net as well.
Artem
On 09/07/2016 12:28 PM, Artem Smotrakov wrote:
Hello,
Please review the following patch for
sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java
The test has been observed to fail a couple of times, but it's still
not clear why
11 matches
Mail list logo
