On 4/16/18 9:50 AM, Sibabrata Sahoo wrote:
Now there is only 1 Test file in the deleted list which has duplicate code. Due
to that I have pointed the older JBS bug ID JDK-4936763 in
KeyAgreementTest.java and linked the same to JDK-8184359 too.
Reverted the duplicate code merge in KeySizeTest.j
Sean Mullan
Sent: Wednesday, April 11, 2018 1:42 AM
To: Sibabrata Sahoo ; Adam Petcher
; security-dev@openjdk.java.net
Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves:
curve25519 and curve448
On 4/9/18 10:13 AM, Sibabrata Sahoo wrote:
> Here is the new patch address
On 4/9/18 10:13 AM, Sibabrata Sahoo wrote:
Here is the new patch addressing all comments.
Webrev:http://cr.openjdk.java.net/~ssahoo/8184359/webrev.01/
Changes includes:
1)
KeyAgreementTest.java
KeySizeTest.java
I have ensured no duplicate Test cases exist for the functionality provide
Sahoo ; Adam Petcher
; security-dev@openjdk.java.net
Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves:
curve25519 and curve448
Comments below ...
On 4/2/18 4:07 AM, Sibabrata Sahoo wrote:
> Hi Sean,
>
> My comments In-lined..
>
> Thanks,
> Siba
>
> --
: Develop new tests for using new elliptic curves:
curve25519 and curve448
A few comments so far; have not finished my review yet.
General comment:
Many of these tests test more than XDH. That is fine and good for increasing
coverage, but have you looked through existing tests to see if you are
Hi Sean,
My comments In-lined..
Thanks,
Siba
-Original Message-
From: Sean Mullan
Sent: Saturday, March 31, 2018 12:13 AM
To: Sibabrata Sahoo ; Adam Petcher
; security-dev@openjdk.java.net
Subject: Re: RFR: 8200219: Develop new tests for using new elliptic curves:
curve25519 and
A few comments so far; have not finished my review yet.
General comment:
Many of these tests test more than XDH. That is fine and good for
increasing coverage, but have you looked through existing tests to see
if you are duplicating anything we are already testing and maybe those
tests could
I have a couple of minor comments. I am not a Reviewer, so someone else
will still need to look at this.
KeySizeTest: You can use the byteArrayToHexString that is in Convert in
the test lib. See TestXDH.java for an example of how this method is
imported and used.
MultiThreadTest: In testKeyAgr
