Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]
On Thu, 3 Mar 2022 16:31:41 GMT, Xue-Lei Andrew Fan wrote: >> May I have this test update reviewed? >> >> The certificates used in SSL testing template SSLExampleCert could expired >> in the future (for example >> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not >> always easy to replace the certificates if the template has been used a lot. >> >> This update is trying to use a fixed validation date, so that even the >> certificates are expired the test will continue to work with no surprises. >> >> I also did a few code clean up in this patch. > > Xue-Lei Andrew Fan has updated the pull request incrementally with one > additional commit since the last revision: > > typo introduced in bug ID Marked as reviewed by rhalade (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]
> May I have this test update reviewed? > > The certificates used in SSL testing template SSLExampleCert could expired in > the future (for example > [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not > always easy to replace the certificates if the template has been used a lot. > > This update is trying to use a fixed validation date, so that even the > certificates are expired the test will continue to work with no surprises. > > I also did a few code clean up in this patch. Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: typo introduced in bug ID - Changes: - all: https://git.openjdk.java.net/jdk/pull/7651/files - new: https://git.openjdk.java.net/jdk/pull/7651/files/64c60b39..1099e4be Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7651=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7651=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/7651.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7651/head:pull/7651 PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]
On Tue, 1 Mar 2022 23:25:52 GMT, Rajan Halade wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Chaneg to use DateFormat > > test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26: > >> 24: /** >> 25: * @test >> 26: * @bug 8806542 > > Missed to note earlier. 8806542 is not a valid bug number. It was updated to > 8065422 so this change is not needed. Oops, definitely not an expected update. Thank you for the nice catch. Updated. - PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]
> May I have this test update reviewed? > > The certificates used in SSL testing template SSLExampleCert could expired in > the future (for example > [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not > always easy to replace the certificates if the template has been used a lot. > > This update is trying to use a fixed validation date, so that even the > certificates are expired the test will continue to work with no surprises. > > I also did a few code clean up in this patch. Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Chaneg to use DateFormat - Changes: - all: https://git.openjdk.java.net/jdk/pull/7651/files - new: https://git.openjdk.java.net/jdk/pull/7651/files/2352eea5..64c60b39 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=7651=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=7651=00-01 Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/7651.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7651/head:pull/7651 PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]
On Tue, 1 Mar 2022 23:23:53 GMT, Xue-Lei Andrew Fan wrote: >> May I have this test update reviewed? >> >> The certificates used in SSL testing template SSLExampleCert could expired >> in the future (for example >> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not >> always easy to replace the certificates if the template has been used a lot. >> >> This update is trying to use a fixed validation date, so that even the >> certificates are expired the test will continue to work with no surprises. >> >> I also did a few code clean up in this patch. > > Xue-Lei Andrew Fan has updated the pull request incrementally with one > additional commit since the last revision: > > Chaneg to use DateFormat test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26: > 24: /** > 25: * @test > 26: * @bug 8806542 Missed to note earlier. 8806542 is not a valid bug number. It was updated to 8065422 so this change is not needed. - PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]
On Tue, 1 Mar 2022 22:56:54 GMT, Rajan Halade wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Chaneg to use DateFormat
>
> test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26:
>
>> 24: /**
>> 25: * @test
>> 26: * @bug 8806542 8282511
>
> No need to add a bug id here as this is test only change
Yep.
> test/jdk/javax/net/ssl/templates/SSLExampleCert.java line 373:
>
>> 371: // Set the date for the verifying of certificates.
>> 372: @SuppressWarnings("deprecation")
>> 373: Date verifyingDate = new Date(123, 3, 3);
>
> can DateFormat be used instead to parse Date from a readable string
> representation?
Good catch! Updated in the last commit. Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/7651
Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template
On Tue, 1 Mar 2022 22:38:30 GMT, Xue-Lei Andrew Fan wrote:
> May I have this test update reviewed?
>
> The certificates used in SSL testing template SSLExampleCert could expired in
> the future (for example
> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398). It is not
> always easy to replace the certificates if the template has been used a lot.
>
> This update is trying to use a fixed validation date, so that even the
> certificates are expired the test will continue to work with no surprises.
>
> I also did a few code clean up in this patch.
test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26:
> 24: /**
> 25: * @test
> 26: * @bug 8806542 8282511
No need to add a bug id here as this is test only change
test/jdk/javax/net/ssl/templates/SSLExampleCert.java line 373:
> 371: // Set the date for the verifying of certificates.
> 372: @SuppressWarnings("deprecation")
> 373: Date verifyingDate = new Date(123, 3, 3);
can DateFormat be used instead to parse Date from a readable string
representation?
-
PR: https://git.openjdk.java.net/jdk/pull/7651
