Re: [SMW-devel] SRF: fixes for 1.5.3

2011-03-29 Thread Frank Dengler
Cc: Semantic MediaWiki developers; Frank Dengler; Hans-Jörg Happel Betreff: Re: [SMW-devel] SRF: fixes for 1.5.3 Hi, On Tue, Mar 29, 2011 at 12:17:23PM +0200, Jeroen De Dauw wrote: > > Can you also address Siebrands comment here: > https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Spec

Re: [SMW-devel] SRF: fixes for 1.5.3

2011-03-29 Thread Stephan Robotta
Hi, On Tue, Mar 29, 2011 at 12:17:23PM +0200, Jeroen De Dauw wrote: > > Can you also address Siebrands comment here: > https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84899#c15534 Looking at the code I guess it's the direction in which the graph is build. There are v

Re: [SMW-devel] SRF: fixes for 1.5.3

2011-03-29 Thread Jeroen De Dauw
Hey, Can you also address Siebrands comment here: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84899#c15534 Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- --

Re: [SMW-devel] SRF: fixes for 1.5.3

2011-03-28 Thread Jeroen De Dauw
Hey, Thanks for these fixes, I have committed the patch [0]. I do have some notes on the changes though: * I did not add the getScripts method added by the patch to the timeline format. These scripts are already getting added, and your patch makes no further changes that refer to this method. * I

[SMW-devel] SRF: fixes for 1.5.3

2011-03-28 Thread Stephan Robotta
Hello, I just updated to SRF to the most recent version in our repository. There I noted a problem when using the TagCloud parameter and the query returns subjects with a count of 1 each. This causes a division by zero error. We have some patches (I attached the file) that try to fix some of thes