Re: GSoC: Initial commit on apache-extras

2012-05-05 Thread Mihai Soloi
Hi Eugen, I will get started on it right away. Hello Mihai, Good job. I've took a small peek at the code and it's ok. The next step will be to create a Directory implementation that extends lucene Directory [1] and make the tests so that you can supply a directory implementation. Your impleme

Re: GSoC: Initial commit on apache-extras

2012-05-05 Thread Mihai Soloi
Hi Manuel, I will use the apache code-style, probably with Maven's check-style plug-in, and use 4 spaces instead of tabs, eclipse can do this for me :), I will use the license header and write Java docs from now on out. Thank you, Mihai On 05.05.2012 12:47, Manuel Carrasco Moñino wrote: Ju

Re: GSoC: Initial commit on apache-extras

2012-05-05 Thread Manuel Carrasco Moñino
Just a recommendation about code style, could you use 4 spaces instead of tabs?, it makes the code more readable in the repository. There are a few more points in code-styling which if you consider from the beginning would make easier merge with james in the future (license header, java docs, ...)

Re: GSoC: Initial commit on apache-extras

2012-05-05 Thread Ioan Eugen Stan
Hello Mihai, Good job. I've took a small peek at the code and it's ok. The next step will be to create a Directory implementation that extends lucene Directory [1] and make the tests so that you can supply a directory implementation. Your implementation should just throw exceptions initially, so

GSoC: Initial commit on apache-extras

2012-05-05 Thread Mihai Soloi
Hey Eugen, I've pushed an initial two classes on the apache-extras repo, I created [1]. I've used git versionning, you can clone the repo. I will add more classes, this weekend, this is just the two classes from the Lucene in Action book, updated to the lucene-core 3.6 [1] http://code.google