hg: jdk8/tl/jdk: 7195099: update problem list with RMI test failures

2012-08-30 Thread stuart . marks
Changeset: f9b11772c4b2 Author:smarks Date: 2012-08-30 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9b11772c4b2 7195099: update problem list with RMI test failures Reviewed-by: alanb ! test/ProblemList.txt

hg: jdk8/tl/hotspot: 31 new changesets

2012-08-30 Thread lana . steuck
Changeset: 6898d85cf0bb Author:amurillo Date: 2012-08-10 23:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6898d85cf0bb 7190772: new hotspot build - hs24-b21 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d5ec46c7da5c Author:amurillo Date: 2012-08-15

hg: jdk8/tl/jdk: 3 new changesets

2012-08-30 Thread lana . steuck
Changeset: baf30df50ce3 Author:andrew Date: 2012-08-23 15:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/baf30df50ce3 7192804: Build should not install jvisualvm man page for OpenJDK Summary: OpenJDK builds don't ship VisualVM so shouldn't ship its man page either. Review

hg: jdk8/tl/jdk: 2 new changesets

2012-08-30 Thread sean . mullan
Changeset: 0a2565113920 Author:mullan Date: 2012-08-30 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a2565113920 6995421: Eliminate the static dependency to sun.security.ec.ECKeyFactory Reviewed-by: mullan, vinnie Contributed-by: stephen.flo...@oracle.com ! make/sun/

hg: jdk8/tl/jdk: 7193683: DriverManager Iterator Warning cleanup

2012-08-30 Thread lance . andersen
Changeset: 11bfec75d333 Author:lancea Date: 2012-08-30 13:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11bfec75d333 7193683: DriverManager Iterator Warning cleanup Reviewed-by: lancea Contributed-by: Dan Xu ! src/share/classes/java/sql/DriverManager.java

Re: RR,XS, 7194597 Typeo in com.sun.management.VMOption.toString()

2012-08-30 Thread Mandy Chung
On 8/30/2012 6:55 AM, Dmitry Samersoff wrote: Hi Everybody. Please review the fix. com.sun.management.VMOption.toString() returns "...(read-only)" if writable is true and "...(read-write)" otherwise. http://cr.openjdk.java.net/~dsamersoff/7194597/webrev.01/ Thumbs up. Mandy

Re: RFR: 6879063: SA should use hsdis for disassembly

2012-08-30 Thread Yumin Qi
You are right, agent/make is historic make for engineers who only want build SA alone. Certainly they can do this by make -f sa.make from different platform locations. But that is only for building sa-jdi.jar, for build libsaproc, they have to build after whole hotspot built. In hotspot build th

Re: RR,XS, 7194597 Typeo in com.sun.management.VMOption.toString()

2012-08-30 Thread Alan Bateman
On 30/08/2012 14:55, Dmitry Samersoff wrote: Hi Everybody. Please review the fix. com.sun.management.VMOption.toString() returns "...(read-only)" if writable is true and "...(read-write)" otherwise. http://cr.openjdk.java.net/~dsamersoff/7194597/webrev.01/ Looks okay to me. -Alan

RR,XS, 7194597 Typeo in com.sun.management.VMOption.toString()

2012-08-30 Thread Dmitry Samersoff
Hi Everybody. Please review the fix. com.sun.management.VMOption.toString() returns "...(read-only)" if writable is true and "...(read-write)" otherwise. http://cr.openjdk.java.net/~dsamersoff/7194597/webrev.01/ -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft r

hg: jdk8/tl/jdk: 7193710: ByteArrayOutputStream Javadoc contains unclosed element

2012-08-30 Thread alan . bateman
Changeset: cf492d1199dc Author:dxu Date: 2012-08-30 12:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf492d1199dc 7193710: ByteArrayOutputStream Javadoc contains unclosed element Reviewed-by: dholmes, alanb, ulfzibis ! src/share/classes/java/io/ByteArrayOutputStream.jav

Re: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-08-30 Thread Staffan Larsen
On 30 aug 2012, at 11:31, David Holmes wrote: > On 30/08/2012 5:50 PM, Staffan Larsen wrote: >> The patch looks good to me and I can sponsor the push to JDK8-TL. >> However, you need a review from an official Reviewer as well. > > Reviewed. > > Any way we can get a regression test too? That w

Re: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-08-30 Thread David Holmes
On 30/08/2012 5:50 PM, Staffan Larsen wrote: The patch looks good to me and I can sponsor the push to JDK8-TL. However, you need a review from an official Reviewer as well. Reviewed. Any way we can get a regression test too? David - BTW, I suggest we remove the confusing comment in Java

Re: 7133122: SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not

2012-08-30 Thread Yasumasa Suenaga
Hi, 7 months ago, I submitted a patch to fix this CR. I can't find this CR in list of bugfixes in 7u6 . Which version this CR will be fixed ? Thanks, Yasumasa On 2012/03/01 23:06, Staffan Larsen wrote: > The CR is currently assigned to me, but I haven't had the time to look at it > yet. It

Re: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-08-30 Thread Staffan Larsen
The patch looks good to me and I can sponsor the push to JDK8-TL. However, you need a review from an official Reviewer as well. BTW, I suggest we remove the confusing comment in Java_com_sun_management_OperatingSystem_getTotalPhysicalMemorySize() while we are at it. /Staffan On 30 aug 2012, a

Re: RFR: 6879063: SA should use hsdis for disassembly

2012-08-30 Thread Staffan Larsen
My understanding is that the makefiles in the agent/make are not used by normal build. Normal builds use make//makefiles/sa.make. It's unclear to me why the files under agent/make exist at all (except for historical reasons). /Staffan On 29 aug 2012, at 19:22, Kelly O'Hair wrote: > Makefile

RE: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value

2012-08-30 Thread Dmytro Sheyko
Hi, Could you please review the patch and apply it if it's correct? https://bugs.openjdk.java.net/show_bug.cgi?id=100077 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6853676 Thanks, Dmytro > Date: Wed, 2 Feb 2011 20:09:59 +1000 > From: david.hol...@oracle.com > To: alan.bate...@oracle.com