hg: jdk8/tl/jdk: 8005561: typo in Calendar

2012-12-27 Thread masayoshi . okutsu
Changeset: f3ac419e2bf0 Author:okutsu Date: 2012-12-28 16:39 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3ac419e2bf0 8005561: typo in Calendar Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread Alan Bateman
On 28/12/2012 03:22, Stuart Marks wrote: : Alan, you've fixed a bunch of tests that were missing @run tags at least twice in the past [1], [2]. I observe that this recent changeset [3] removed an @run tag that was necessary to run the test. It's not quite the same pathology, but it demonstrat

hg: jdk8/tl/jdk: 8005277: Regression in JDK 7 in Bidi implementation

2012-12-27 Thread yuka . kamiya
Changeset: 1da019e7999a Author:peytoia Date: 2012-12-28 15:07 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1da019e7999a 8005277: Regression in JDK 7 in Bidi implementation Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java ! test/java/text/Bidi/BidiConform

hg: hsx/hotspot-rt/langtools: 10 new changesets

2012-12-27 Thread john . coomes
Changeset: c78acf6c2f3e Author:mcimadamore Date: 2012-12-10 12:10 + URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c78acf6c2f3e 8004094: Javac compiler error - synthetic method accessor generated with duplicate name Summary: method clash check logic should skip me

hg: hsx/hotspot-rt/jdk: 52 new changesets

2012-12-27 Thread john . coomes
Changeset: e8b54ae97344 Author:jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8b54ae97344 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: f

hg: hsx/hotspot-rt/jaxws: 2 new changesets

2012-12-27 Thread john . coomes
Changeset: 3b1c2733d47e Author:katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/3b1c2733d47e Added tag jdk8-b69 for changeset 756323c99011 ! .hgtags Changeset: f577a39c9fb3 Author:katleman Date: 2012-12-27 12:15 -0800 URL:

hg: hsx/hotspot-rt/jaxp: 4 new changesets

2012-12-27 Thread john . coomes
Changeset: 27421008f050 Author:katleman Date: 2012-12-20 09:18 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/27421008f050 Added tag jdk8-b69 for changeset 789a855de959 ! .hgtags Changeset: a72c8391cdd6 Author:katleman Date: 2012-12-20 16:23 -0800 URL:

hg: hsx/hotspot-rt/corba: 2 new changesets

2012-12-27 Thread john . coomes
Changeset: 603cceb495c8 Author:katleman Date: 2012-12-20 09:17 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/603cceb495c8 Added tag jdk8-b69 for changeset 22ddcac208a8 ! .hgtags Changeset: 8171d23e914d Author:katleman Date: 2012-12-27 12:14 -0800 URL:

hg: hsx/hotspot-rt: 10 new changesets

2012-12-27 Thread john . coomes
Changeset: fb1bf5e5bc9e Author:henryjen Date: 2012-12-06 15:38 -0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/fb1bf5e5bc9e 8004685: add java.util.function to CORE_PKGS.gmk Reviewed-by: mduigou ! common/makefiles/javadoc/CORE_PKGS.gmk Changeset: e08b0096058f Author:la

hg: jdk8/tl/jdk: 8005471: DateFormat: Time zone info is not localized when adapter is CLDR

2012-12-27 Thread masayoshi . okutsu
Changeset: 4ad38db38fff Author:okutsu Date: 2012-12-28 14:13 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad38db38fff 8005471: DateFormat: Time zone info is not localized when adapter is CLDR Reviewed-by: peytoia ! src/share/classes/sun/util/resources/TimeZoneNamesBundle.

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread Stuart Marks
On 12/27/12 2:31 PM, Alan Bateman wrote: On 27/12/2012 18:19, Stuart Marks wrote: It's true that one can omit the @run tag and single-file tests like this one will get built and run by default. My advice, however, is to use the @run tag even when one isn't strictly required. My comment was on t

hg: jdk8/tl/jaxp: 8005473: Warnings compiling jaxp

2012-12-27 Thread huizhe . wang
Changeset: d4aea0225e80 Author:joehw Date: 2012-12-27 18:17 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d4aea0225e80 8005473: Warnings compiling jaxp Summary: clean up compiling warnings. Reviewed-by: weijun, chegar, forax ! src/com/sun/org/apache/xalan/internal/xslt/Env

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread Alan Bateman
On 27/12/2012 18:19, Stuart Marks wrote: I hate to contradict Alan on this It's true that one can omit the @run tag and single-file tests like this one will get built and run by default. My advice, however, is to use the @run tag even when one isn't strictly required. My comment was on th

hg: jdk8/tl/jdk: 8003981: Support Parallel Array Sorting - JEP 103

2012-12-27 Thread chris . hegarty
Changeset: 9d984ccd17fc Author:chegar Date: 2012-12-27 21:55 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d984ccd17fc 8003981: Support Parallel Array Sorting - JEP 103 Reviewed-by: chegar, forax, dholmes, dl Contributed-by: [email protected], [email protected], chr

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread Stuart Marks
I hate to contradict Alan on this It's true that one can omit the @run tag and single-file tests like this one will get built and run by default. My advice, however, is to use the @run tag even when one isn't strictly required. The reason has to do with jtreg's rules of when it decides to

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread Alan Bateman
On 27/12/2012 11:33, shanliang wrote: Thanks for all comments, here is the new webrev: http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.03/ Indeed, no need to have @run for the test. Shanliang Thanks, it looks okay to me now. -Alan

Re: RFR JDK-8005120

2012-12-27 Thread Dmitry Samersoff
John, socket_md.c:88 (and other similar places) socklen_t nBytes should be size_t nbytes Otherwise looks good for me. -Dmitry On 2012-12-26 23:56, John Zavgren wrote: > Greetings: > I modified the windows code so that it uses socklen_t to specify the > lengths of data structures, parameter

Re: jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

2012-12-27 Thread shanliang
Thanks for all comments, here is the new webrev: http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.03/ Indeed, no need to have @run for the test. Shanliang Alan Bateman wrote: On 26/12/2012 15:07, shanliang wrote: Yes should use a cop[y, it is a mistake to use a unmodifiable view. Her