On 28/12/2012 03:22, Stuart Marks wrote:
:
Alan, you've fixed a bunch of tests that were missing @run tags at
least twice in the past [1], [2]. I observe that this recent changeset
[3] removed an @run tag that was necessary to run the test. It's not
quite the same pathology, but it demonstrates that it's pretty easy to
get the jtreg tags wrong.
Sorry Shanliang, I'm using your changeset as a springboard for this
discussion of jtreg tag style. I really do recommend that each test
include an explicit @run tag, since the tags are so easy to get wrong.
That's fine, my main observation (after fixing several of these) is that
the mistake happen once it becomes necessary to use @build or @compile.
It is really easy to not observe that the test isn't actually executed
if there isn't an @run. Anyway, I think this is something for a regular
checking script to check for, it just needs to have a list of the
compile-only tests so that it doesn't flag as missing a tag.
-Alan
