hg: jdk8/tl/jdk: 8016110: Japanese char (MS932) 0x5C cannot be used as an argument when quoted

Changeset: b4c259743371 Author:naoto Date: 2013-09-30 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4c259743371 8016110: Japanese char (MS932) 0x5C cannot be used as an argument when quoted Reviewed-by: ksrini, akhil ! src/windows/bin/cmdtoargs.c + test/tools/launche

hg: jdk8/tl/jdk: 8009438: sun/security/pkcs11/Secmod tests failing on Ubuntu 12.04

Changeset: e4c897b33cb7 Author:ascarpino Date: 2013-09-02 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4c897b33cb7 8009438: sun/security/pkcs11/Secmod tests failing on Ubuntu 12.04 Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/Secmod.java

hg: jdk8/tl/jdk: 8004283: test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failing intermittently

Changeset: 2434e79fc41f Author:ascarpino Date: 2013-09-18 14:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2434e79fc41f 8004283: test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failing intermittently Reviewed-by: vinnie ! test/sun/security/pkcs11/KeyStore/SecretKey

hg: jdk8/tl/jdk: 7122707: Security Providers need to have their version numbers updated for JDK8

Changeset: d0de46a2cbd0 Author:ascarpino Date: 2013-09-19 11:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d0de46a2cbd0 7122707: Security Providers need to have their version numbers updated for JDK8 Reviewed-by: xuelei ! src/macosx/classes/apple/security/AppleProvider.j

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

On 30 sep 2013, at 15:44, Daniel D. Daugherty wrote: > On 9/30/13 7:13 AM, Staffan Larsen wrote: >> First: thanks for doing this work - it will make debugging on os x so much >> easier! > > That's the plan... > > >> I'm not done with the review, but here are a couple of comments so far. >>

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

On 9/30/13 8:12 AM, Vadim Pakhnushev wrote: BTW, I have the same issue on windows: make[2]: *** No rule to make target `/cygdrive/c/Vadim/jdk8_2d/build/windows-x86-normal-server-release/jdk/bin/verify.map', needed by `all'. Stop. I think it can be fixed by this: diff -r d4762f463fe0 common/

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

BTW, I have the same issue on windows: make[2]: *** No rule to make target `/cygdrive/c/Vadim/jdk8_2d/build/windows-x86-normal-server-release/jdk/bin/verify.map', needed by `all'. Stop. I think it can be fixed by this: diff -r d4762f463fe0 common/makefiles/NativeCompilation.gmk --- a/common/

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

On 9/30/13 7:13 AM, Staffan Larsen wrote: First: thanks for doing this work - it will make debugging on os x so much easier! That's the plan... I'm not done with the review, but here are a couple of comments so far. I tried running with: $ sh ./configure --with-debug-level=slowdebug --dis

hg: jdk8/tl/jdk: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

Changeset: ede1fd12e0da Author:allwin Date: 2013-09-30 14:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ede1fd12e0da 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c Reviewed-by: chegar, sla, sspitsyn, mgronlun ! src/windows/demo/jv

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

First: thanks for doing this work - it will make debugging on os x so much easier! I'm not done with the review, but here are a couple of comments so far. I tried running with: $ sh ./configure --with-debug-level=slowdebug --disable-zip-debug-info $ make which results in: ## Starting hotspot .

Re: jmx-dev Codereview request: 8025207 Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java

+1 -JB- On 30.9.2013 15:05, Daniel Fuchs wrote: The new version looks good to me. Thanks Shanliang! -- daniel On 9/24/13 1:22 PM, shanliang wrote: Daniel Fuchs wrote: On 9/23/13 8:27 PM, shanliang wrote: Hi, Please review this test fix, if the test continues failing, then we need to inve

Re: jmx-dev Codereview request: 8025207 Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java

The new version looks good to me. Thanks Shanliang! -- daniel On 9/24/13 1:22 PM, shanliang wrote: Daniel Fuchs wrote: On 9/23/13 8:27 PM, shanliang wrote: Hi, Please review this test fix, if the test continues failing, then we need to investigate the Monitor implementation. webrev: http:/

Re: RFR (S): JDK-8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes

Fredrik, On 09/30/2013 01:45 PM, Fredrik Arvidsson wrote: Hi Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8024423 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.00/

Re: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

> On 30 Sep 2013, at 13:06, Peter Allwin wrote: > > Thanks everyone for the reviews, just need a JDK reviewer to approve this! The changes look good to me. -Chris. > > /peter > >> On Sep 16, 2013, at 5:44 PM, Peter Allwin wrote: >> >> Hello! >> >> Please review this simple fix for a pot

Re: JDK-7090324: gclog rotation via external tool

In previous email, I've attached new patch for this RFE. It works fine with current hsx. Yasumasa On 2013/09/29 23:40, Yasu wrote: Hi all, We are using "logrotate" tool on RHEL for various log rotation. Current HotSpot has gclog rotation function for log size base, however I need to rotate gc

Re: RFR: 8012923: [parfait] File Descriptor Leak in jdk/src/windows/demo/jvmti/hprof/hprof_md.c

Thanks everyone for the reviews, just need a JDK reviewer to approve this! /peter On Sep 16, 2013, at 5:44 PM, Peter Allwin wrote: > Hello! > > Please review this simple fix for a potential socket handle leak in the hprof > agent's windows implementation, as discovered by parfait. > > bug: h

RFR (S): JDK-8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes

Hi Please help me to review the changes below: Jira case: https://bugs.openjdk.java.net/browse/JDK-8024423 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.00/ In this review I still have an outstanding unans

hg: jdk8/tl/jdk: 8023492: jfr.jar gets loaded even though it's not used

Changeset: cceaad499685 Author:sla Date: 2013-09-30 12:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cceaad499685 8023492: jfr.jar gets loaded even though it's not used Reviewed-by: erikj, mgronlun ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java

Re: RFR: 6696975: JTop plugin fails if connected readonly to target JVM

Thanks for the review Erik Mandy Chung skrev 2013-09-27 21:10: On 9/27/13 11:58 AM, Michel Trudeau wrote: Here is the latest change: http://cr.openjdk.java.net/~egahlin/6696975_2/ The change looks okay to me. This will rely on your manual testing to verify the fix :) Mandy

RE: RFR: 8023492 jfr.jar gets loaded even though it's not used

Looks good Staffan, thanks for fixing. /Markus -Original Message- From: Staffan Larsen Sent: den 30 september 2013 10:00 To: build-...@openjdk.java.net build-dev; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: RFR: 8023492 jfr.jar gets loaded even thoug

hg: jdk8/tl/jdk: 8009719: core reflection should get type annotation data from the VM lazily

Changeset: 89174cddaec8 Author:jfranck Date: 2013-09-30 12:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89174cddaec8 8009719: core reflection should get type annotation data from the VM lazily Summary: Remove typeAnnotations field from Method, Constructor, and Field, up

hg: jdk8/tl/jdk: 8007072: Update Core Reflection for Type Annotations to match latest spec; ...

Changeset: 15955d335cd0 Author:jfranck Date: 2013-09-30 11:18 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/15955d335cd0 8007072: Update Core Reflection for Type Annotations to match latest spec 8022324: j.l.Class.getAnnotatedInterfaces() for array type returns wrong value 8

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Looks good! -- daniel On 9/30/13 11:47 AM, shanliang wrote: Daniel Fuchs wrote: Hi Shanliang, Shouldn't 'messageReceived' be at least declared as volatile? It looks as if this test is a multi-thread test which is not MT-safe. OK I am convinced: http://cr.openjdk.java.net/~sjiang/JDK-80

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Daniel Fuchs wrote: Hi Shanliang, Shouldn't 'messageReceived' be at least declared as volatile? It looks as if this test is a multi-thread test which is not MT-safe. OK I am convinced: http://cr.openjdk.java.net/~sjiang/JDK-8025206/02/ Thanks, Shanliang cheers, -- daniel On 9/30/13 8:

Re: RFR: 8023492 jfr.jar gets loaded even though it's not used

Looks good to me. Also verified that nothing else changed in the meta-index files. /Erik On 2013-09-30 09:59, Staffan Larsen wrote: When running a program that has code in the com.oracle.* package, jfr.jar will be loaded even if JFR is not referenced. This is because jre/lib/meta-index says

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Daniel Fuchs wrote: Hi Shanliang, Shouldn't 'messageReceived' be at least declared as volatile? It looks as if this test is a multi-thread test which is not MT-safe. Could be better, but the test is patient enough with its timeout :) Shanliang cheers, -- daniel On 9/30/13 8:55 AM, shanlia

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Hi Shanliang, Shouldn't 'messageReceived' be at least declared as volatile? It looks as if this test is a multi-thread test which is not MT-safe. cheers, -- daniel On 9/30/13 8:55 AM, shanliang wrote: Hi, Please review this test fix, I set a much long waiting time to receive a notification,

RFR: 8023492 jfr.jar gets loaded even though it's not used

When running a program that has code in the com.oracle.* package, jfr.jar will be loaded even if JFR is not referenced. This is because jre/lib/meta-index says that jfr.jar contains code for com.oracle.*. While this is true, it is a bit too general. It would be more accurate to say that jfr.jar

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Hi, On 30.9.2013 09:46, shanliang wrote: Thanks Jaroslav for the review, here is the new version with the debugging info: http://cr.openjdk.java.net/~sjiang/JDK-8025206/01/ I'm fine with the changes. -JB- Shanliang Jaroslav Bachorik wrote: Hi Shanliang, On 30.9.2013 08:55, shanliang

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Thanks Jaroslav for the review, here is the new version with the debugging info: http://cr.openjdk.java.net/~sjiang/JDK-8025206/01/ Shanliang Jaroslav Bachorik wrote: Hi Shanliang, On 30.9.2013 08:55, shanliang wrote: Hi, Please review this test fix, I set a much long waiting time to rec

Re: jmx-dev Codereview request: 8025206 IIntermittent test failure: javax/management/monitor/NullAttributeValueTest.java

Hi Shanliang, On 30.9.2013 08:55, shanliang wrote: Hi, Please review this test fix, I set a much long waiting time to receive a notification, but not simply wait the test timeout, in order to have less modification. IMO, the change to let the harness terminate the test on timeout was quite r