If you have a preliminary patch then I would suggest bringing it to
serviceability-dev to discuss it.
-Alan
On 14/11/2013 03:17, Eric Wang wrote:
Hi Everyone,
I'm working on the bug https://bugs.openjdk.java.net/browse/JDK-7067973.
It is a test bug as the test doesn't guarantee memory all
Still looking for an official Review of this change.
Thanks,
/Staffan
On 11 Nov 2013, at 10:32, Staffan Larsen wrote:
> Thanks Serguei!
>
> Can I have an official Review as well?
>
> /Staffan
>
> On 04 Nov 2013, at 21:08, serguei.spit...@oracle.com wrote:
>
>> Staffan,
>>
>> This one is re
Still looking for an official Review of this change.
Thanks,
/Staffan
On 11 Nov 2013, at 19:42, Staffan Larsen wrote:
> Please review this small fix to output SA message to stdout instead of stderr.
>
> webrev: http://cr.openjdk.java.net/~sla/6626412/webrev.00/
> bug: https://bugs.openjdk.java
Still looking for an official Review of this change.
Thanks,
/Staffan
On 11 Nov 2013, at 21:25, Staffan Larsen wrote:
> Ah, good catch.
>
> Here is an updated review: http://cr.openjdk.java.net/~sla/6606002/webrev.01/
>
> Thanks,
> /Staffan
>
> On 11 Nov 2013, at 21:06, serguei.spit...@oracl
Still looking for an official Review of this change.
Thanks,
/Staffan
On 11 Nov 2013, at 20:49, Staffan Larsen wrote:
> The contract for the tools should be (similarly from other tools, eg javac):
>
> If the arguments are wrong or not specified: exit code != 0, usage output on
> stderr
> If -
Changeset: 1d790a56de4e
Author:sherman
Date: 2013-11-13 22:22 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d790a56de4e
8028321: Fix for String.split() empty input sequence/JDK-6559590 triggers
regression
Summary: to undo the change for 6559590
Reviewed-by: darcy
! src/sh
Changeset: cdf20166ec45
Author:minqi
Date: 2013-11-13 16:24 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cdf20166ec45
8025632: Remove all references to MagicLambdaImpl from Hotspot
Summary: MagicLambdaImpl was removed from jdk side, this should be done in vm
sid
Changeset: f90d88913c5f
Author:sogoel
Date: 2013-11-13 16:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f90d88913c5f
8025113: Convert 7 tools TryWithResources tests to jtreg format
Reviewed-by: darcy, jjg
+ test/tools/javac/TryWithResources/ResDeclOutsideTry.java
+
Changeset: 41cb10cbfb3c
Author:coleenp
Date: 2013-11-13 16:42 -0500
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41cb10cbfb3c
8025937: assert(existing_f1 == NULL || existing_f1 == f1) failed: illegal field
change
Summary: Create extra constant pool cache entries for
Changeset: ea91826bc2e9
Author:emc
Date: 2013-11-13 15:48 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ea91826bc2e9
8026884: test for fix of JDK-8021398 does not have @bug tag
8028021: @since 1.8 missing for certain methods in java.lang.reflect.Method in
generated api docs
Changeset: 5b84039ca739
Author:amurillo
Date: 2013-11-01 08:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5b84039ca739
8027580: new hotspot build - hs25-b58
Reviewed-by: jcoomes
! make/hotspot_version
Changeset: ea79ab313e98
Author:mgerdin
Date: 2013-10-30
Changeset: 9e37caf07ce0
Author:sherman
Date: 2013-11-13 11:26 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e37caf07ce0
8027645: Pattern.split() with positive lookahead
6559590: Pattern.compile(".*").split("") returns incorrect result
Summary: updated spec/impl for these tw
Changeset: e6333788b117
Author:darcy
Date: 2013-11-13 11:06 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6333788b117
8028300: Fix raw type lint warnings in java.util.concurrent
Reviewed-by: chegar, martin
! src/share/classes/java/util/concurrent/ForkJoinPool.java
! src/sh
Changeset: fce21ac5968d
Author:acorn
Date: 2013-11-13 07:31 -0800
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fce21ac5968d
8027229: ICCE expected for >=2 maximally specific default methods.
Summary: Need to process defaults for interfaces for invokespecial
Reviewed-by
Changeset: 256b3395346b
Author:egahlin
Date: 2013-11-13 18:41 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/256b3395346b
6954510: TEST_BUG: Testcase failure com/sun/jdi/BreakpointWithFullGC.sh
Reviewed-by: sla, sspitsyn
! test/com/sun/jdi/BreakpointWithFullGC.sh
Changeset: a493871959c2
Author:alanb
Date: 2013-11-13 16:52 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a493871959c2
8028270: Files.readSymbolicLink calls AccessController directly so security
manager can't grant the permission
Reviewed-by: mchung, martin, chegar
! src/s
Changeset: 70f1bed5e7fd
Author:chegar
Date: 2013-11-13 16:44 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f1bed5e7fd
8022213: Intermittent test failures in java/net/URLClassLoader
Reviewed-by: dxu, alanb
! test/java/net/URLClassLoader/closetest/CloseTest.java
! test/java
Changeset: 7c55fecfae65
Author:mchung
Date: 2013-11-13 07:49 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c55fecfae65
8028234: Remove unused methods in sun.misc.JavaAWTAccess
Reviewed-by: art, dfuchs, lancea
! src/share/classes/sun/awt/AppContext.java
! src/share/classes/
Changeset: a42a416351b8
Author:ykantser
Date: 2013-11-13 11:46 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a42a416351b8
8015497: Take new fixes from hotspot/test/testlibrary to
jdk/test/lib/testlibrary
Reviewed-by: sla
+ test/lib/testlibrary/AssertsTest.java
+ test/lib/t
Changeset: ddaa9a8acaed
Author:egahlin
Date: 2013-11-13 15:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddaa9a8acaed
6959636: testcase failing on windows
javax/management/loading/LibraryLoader/LibraryLoaderTest.java
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
!
Changeset: 680ef14a2cc0
Author:jbachorik
Date: 2013-11-13 13:12 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/680ef14a2cc0
8004126: TEST_BUG: com/sun/jdi/BadHandshakeTest.java fails intermittently
Reviewed-by: dholmes, ykantser
! test/com/sun/jdi/BadHandshakeTest.java
On 11/13/2013 11:23 AM, Staffan Larsen wrote:
Assuming that you have verified the changes by running relevant tests this
looks good.
Yes, I did. Thanks!
Reviewed.
Thanks,
/Staffan
On 07 Nov 2013, at 16:48, Yekaterina Kantserova
wrote:
Adding hotspot-dev group.
Original Messag
Assuming that you have verified the changes by running relevant tests this
looks good.
Reviewed.
Thanks,
/Staffan
On 07 Nov 2013, at 16:48, Yekaterina Kantserova
wrote:
> Adding hotspot-dev group.
>
> Original Message
> Subject: RFR (S): 8015497: Take new fixes from h
Looks good! Sorry for taking so long to review.
./test/lib/testlibrary/jdk/testlibrary/Utils.java
L78: nit: missing spaces around = and <
/Staffan
On 08 Nov 2013, at 15:48, Mattias Tobiasson
wrote:
> Hi,
> Could you please review this fix.
> The tests for java/lang/instrument/PremainClass/P
Changeset: 30a3aefc4084
Author:dfuchs
Date: 2013-11-13 10:50 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/30a3aefc4084
8026952: Test
java/util/logging/LogManager/RootLogger/setLevel/TestRootLoggerLevel.java has
wrong @bug id
Summary: Trivial: change @bug 8023163 into @bug
Changeset: 1158d504e39e
Author:xuelei
Date: 2013-11-13 01:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1158d504e39e
8023147: Test DisabledShortRSAKeys.java intermittent failed
Reviewed-by: mullan
! test/sun/security/ssl/javax/net/ssl/TLSv12/DisabledShortRSAKeys.java
Hi again!
Thank you for spotting these! I'm sorry, silly mistakes.
I have updated lines 51-53 to:
51 inline bool operator<=(const Tickspan& lhs, const Tickspan& rhs) {
52 return !operator>(lhs,rhs);
53 }
And lines 97-99 as:
97 inline bool operator<=(const Ticks& lhs, c
Looks good!
Thanks,
/Staffan
On 12 Nov 2013, at 21:33, Erik Gahlin wrote:
> Could I please have a review of a regression test that fails intermittently
> because a full GC is not always triggered.
>
> Fix is to call System.gc()
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/6954510_1
>
>
28 matches
Mail list logo
