RFR 8067241 DeadlockTest.java failed with negative timeout value

2014-12-11 Thread shanliang
Hi, It is a test bug, it is not correct: while(!wb.done || timeToWait > 0) { it should be: while(!wb.done && timeToWait > 0) { || should be changed to && Another issue is that the waiting time could be not enough (final long timeout = 2000). The fix is to remove the waiting time specifi

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread Dmitry Samersoff
Stuart, As soon as you close socket, you open a door for the race. So you need another communication channel to pass a port number (or bind result) between a client and a server without closing a socket on the server side. Typical scenario used by network related code is: 1. Server opens the so

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread Stuart Marks
On 12/11/14 7:09 AM, [email protected] wrote: On 11/12/2014 15:43, Dmitry Samersoff wrote: You can set SO_LINGER to zero, in this case socket will be closed immediately without waiting in TIME_WAIT SO-LINGER did not help either in my case (see my previous mail to Jaroslav). That ende

Re: RFR 8066863: bigapps/runThese/nowarnings fails: Java HotSpot(TM) 64-Bit Server VM warning: WaitForMultipleObjects

2014-12-11 Thread Ivan Gerasimov
On 11.12.2014 19:05, Daniel D. Daugherty wrote: On 12/11/14 3:01 AM, David Holmes wrote: On 11/12/2014 7:48 PM, David Holmes wrote: Hi Ivan, On 11/12/2014 4:52 PM, Ivan Gerasimov wrote: Hello! After the fix for JDK-8064694 some more failures of WaitForMultipleObjects() were observed under h

Re: RFR 8066863: bigapps/runThese/nowarnings fails: Java HotSpot(TM) 64-Bit Server VM warning: WaitForMultipleObjects

2014-12-11 Thread Ivan Gerasimov
On 11.12.2014 13:01, David Holmes wrote: On 11/12/2014 7:48 PM, David Holmes wrote: Hi Ivan, On 11/12/2014 4:52 PM, Ivan Gerasimov wrote: Hello! After the fix for JDK-8064694 some more failures of WaitForMultipleObjects() were observed under heavy load. The reason was that the limitation on

Re: RFR(L): 8049716: PPC64: Implement SA on Linux/PPC64

2014-12-11 Thread Dmitry Samersoff
Volker, Below is fist part of review - shared files. * agent/make/Makefile - no comments * agent/src/os/linux/LinuxDebuggerLocal.c - no comments * agent/src/os/linux/symtab.c: 438: - What is the magic of symbols that starts with '.' ? - As far as I understand you are getting indirect valu

Re: RFR 8066863: bigapps/runThese/nowarnings fails: Java HotSpot(TM) 64-Bit Server VM warning: WaitForMultipleObjects

2014-12-11 Thread Daniel D. Daugherty
On 12/11/14 3:01 AM, David Holmes wrote: On 11/12/2014 7:48 PM, David Holmes wrote: Hi Ivan, On 11/12/2014 4:52 PM, Ivan Gerasimov wrote: Hello! After the fix for JDK-8064694 some more failures of WaitForMultipleObjects() were observed under heavy load. The reason was that the limitation on w

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread [email protected]
Hi Dmitry, On 11/12/2014 15:43, Dmitry Samersoff wrote: Jaroslav, You can set SO_LINGER to zero, in this case socket will be closed immediately without waiting in TIME_WAIT SO-LINGER did not help either in my case (see my previous mail to Jaroslav). That ended-up in using another hard-coded (s

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread [email protected]
Hi Jaroslav, On 11/12/2014 15:06, Jaroslav Bachorik wrote: Further investigation shows that the problem was rather the client connecting to a socket being shut down. I remember I met this situation for an RMI fix a while ago and IIRC no flag setting could help (SO_REUSEADDR as well), the port

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread Dmitry Samersoff
Jaroslav, You can set SO_LINGER to zero, in this case socket will be closed immediately without waiting in TIME_WAIT But there are no reliable way to predict whether you can take this port or not after you close it. So the only valid solution is to try to connect to a random port and if this att

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

2014-12-11 Thread Jaroslav Bachorik
On 12/09/2014 01:25 PM, Jaroslav Bachorik wrote: On 12/09/2014 01:39 AM, Stuart Marks wrote: On 12/8/14 12:35 PM, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8066708 Webrev: http://cr.openjdk.java.net/~jbachorik/8066708/web

Re: RFR 8066863: bigapps/runThese/nowarnings fails: Java HotSpot(TM) 64-Bit Server VM warning: WaitForMultipleObjects

2014-12-11 Thread David Holmes
On 11/12/2014 7:48 PM, David Holmes wrote: Hi Ivan, On 11/12/2014 4:52 PM, Ivan Gerasimov wrote: Hello! After the fix for JDK-8064694 some more failures of WaitForMultipleObjects() were observed under heavy load. The reason was that the limitation on wait object number was overlooked. The tota

Re: RFR 8066863: bigapps/runThese/nowarnings fails: Java HotSpot(TM) 64-Bit Server VM warning: WaitForMultipleObjects

2014-12-11 Thread David Holmes
Hi Ivan, On 11/12/2014 4:52 PM, Ivan Gerasimov wrote: Hello! After the fix for JDK-8064694 some more failures of WaitForMultipleObjects() were observed under heavy load. The reason was that the limitation on wait object number was overlooked. The total number of the objects should not be greate

Re: RFR(S): 8067030 JDWP crash in transport_startTransport on OOM

2014-12-11 Thread Jaroslav Bachorik
Hi, Looks good! -JB- On 12/11/2014 09:48 AM, Dmitry Samersoff wrote: Serguei, Fixed two more missed error checks (in-place, press shift-reload) http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/ -Dmitry On 2014-12-10 01:30, [email protected] wrote: Hi Dmitry, The fix

Re: RFR(S): 8067030 JDWP crash in transport_startTransport on OOM

2014-12-11 Thread [email protected]
Dmitry, It looks good. Reviewed. Thank you for fixing two more cases! Thanks, Serguei On 12/11/14 12:48 AM, Dmitry Samersoff wrote: Serguei, Fixed two more missed error checks (in-place, press shift-reload) http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/ -Dmitry On 2014-12-10

Re: RFR(S): 8067030 JDWP crash in transport_startTransport on OOM

2014-12-11 Thread Dmitry Samersoff
Serguei, Fixed two more missed error checks (in-place, press shift-reload) http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/ -Dmitry On 2014-12-10 01:30, [email protected] wrote: > Hi Dmitry, > > The fix looks good. > > However, there are a couple of more places in that f