Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread Mandy Chung
> On Dec 7, 2015, at 7:42 PM, David Holmes wrote: > > On 8/12/2015 1:54 AM, Roger Riggs wrote: >> Hi Jaroslav, >> >> Is this just to accommodate the test library? I found no other >> references in java.base. >> >> If so, then perhaps it can be placed in another package that the tests >> routi

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread David Holmes
On 8/12/2015 1:54 AM, Roger Riggs wrote: Hi Jaroslav, Is this just to accommodate the test library? I found no other references in java.base. If so, then perhaps it can be placed in another package that the tests routinely need access to. Does this fit the scope of the WhiteBox? The original

Re: [ping] Re: RFR 8144308: com/sun/jdi/SuspendThreadTest.java failed with "transport error 202: send failed: Broken pipe"

2015-12-07 Thread David Holmes
On 8/12/2015 6:54 AM, serguei.spit...@oracle.com wrote: Hi Jaroslav, Looks good. Would it more clean with the "volatile" keyword ? 45 public static boolean active = true; If set and read in different threads then it must be volatile. Else C2 can turn it into an if-check outside an infinite l

Re: RFR[ 9u-dev] JDK-8138745: Implement ExitOnOutOfMemory and CrashOnOutOfMemory in HotSpot

2015-12-07 Thread David Holmes
Hi Cheleswer, Thanks. Just a few minor updates ... On 3/12/2015 4:58 PM, cheleswer sahu wrote: Hi, Thanks David and Staffan for your comments. Please review the code changes in the updated webrev below http://cr.openjdk.java.net/~kevinw/8138745/webrev.01/ src/share/vm/runtime/globals.hpp As

Re: [ping] Re: RFR 8144308: com/sun/jdi/SuspendThreadTest.java failed with "transport error 202: send failed: Broken pipe"

2015-12-07 Thread serguei.spit...@oracle.com
Hi Jaroslav, Looks good. Would it more clean with the "volatile" keyword ? 45 public static boolean active = true; Thanks, Serguei On 12/7/15 00:43, Jaroslav Bachorik wrote: On 1.12.2015 18:33, Jaroslav Bachorik wrote: Please, review the following simple test change Issue : https://bugs.op

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

2015-12-07 Thread Marcus Larsson
Thanks Staffan! Marcus On 2015-12-07 15:43, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 4 dec. 2015, at 15:46, Marcus Larsson wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This allows usage of a 'class' tag, for example. Tag

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread Roger Riggs
Hi Jaroslav, Is this just to accommodate the test library? I found no other references in java.base. If so, then perhaps it can be placed in another package that the tests routinely need access to. Does this fit the scope of the WhiteBox? Thanks, Roger On 12/07/2015 06:23 AM, Jaroslav B

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

2015-12-07 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 4 dec. 2015, at 15:46, Marcus Larsson wrote: > > Hi, > > Please review the following patch to allow C++ reserved keywords to be used > as UL tags. This allows usage of a 'class' tag, for example. > > Tags are now automatically prefixed with underscores by th

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

2015-12-07 Thread Marcus Larsson
On 2015-12-07 12:16, David Holmes wrote: On 7/12/2015 5:58 PM, Marcus Larsson wrote: Hi David, On 2015-12-07 07:26, David Holmes wrote: Hi Marcus, On 5/12/2015 12:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread Jaroslav Bachorik
On 7.12.2015 12:20, David Holmes wrote: On 7/12/2015 6:46 PM, Jaroslav Bachorik wrote: > On 27.11.2015 13:21, Jaroslav Bachorik wrote: >> On 26.11.2015 12:59, Jaroslav Bachorik wrote: >>> On 26.11.2015 12:48, Jaroslav Bachorik wrote: On 25.11.2015 04:11, Mandy Chung wrote: > > > On N

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread David Holmes
On 7/12/2015 6:46 PM, Jaroslav Bachorik wrote: On 27.11.2015 13:21, Jaroslav Bachorik wrote: On 26.11.2015 12:59, Jaroslav Bachorik wrote: On 26.11.2015 12:48, Jaroslav Bachorik wrote: On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/20

Re: RFR: 8144146: Unified Logging tags cannot be reserved keywords

2015-12-07 Thread David Holmes
On 7/12/2015 5:58 PM, Marcus Larsson wrote: Hi David, On 2015-12-07 07:26, David Holmes wrote: Hi Marcus, On 5/12/2015 12:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to allow C++ reserved keywords to be used as UL tags. This allows usage of a 'class' tag, for example.

Re: RFR 8144308: com/sun/jdi/SuspendThreadTest.java failed with "transport error 202: send failed: Broken pipe"

2015-12-07 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 1 dec. 2015, at 18:33, Jaroslav Bachorik > wrote: > > Please, review the following simple test change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8144308 > Webrev: http://cr.openjdk.java.net/~jbachorik/8144308/webrev.00 > > The test keeps the debugg

Re: [preview] Adding java.lang.Runtime.getVMArguments() method

2015-12-07 Thread Jaroslav Bachorik
On 27.11.2015 13:21, Jaroslav Bachorik wrote: On 26.11.2015 12:59, Jaroslav Bachorik wrote: On 26.11.2015 12:48, Jaroslav Bachorik wrote: On 25.11.2015 04:11, Mandy Chung wrote: > On Nov 24, 2015, at 6:24 PM, David Holmes wrote: > > On 25/11/2015 10:06 AM, Mandy Chung wrote: >> >>> On Nov 24

[ping] Re: RFR 8144308: com/sun/jdi/SuspendThreadTest.java failed with "transport error 202: send failed: Broken pipe"

2015-12-07 Thread Jaroslav Bachorik
On 1.12.2015 18:33, Jaroslav Bachorik wrote: Please, review the following simple test change Issue : https://bugs.openjdk.java.net/browse/JDK-8144308 Webrev: http://cr.openjdk.java.net/~jbachorik/8144308/webrev.00 The test keeps the debuggee spinning in a loop and does not stop it once the test