Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

We need a second reviewer. Could you review it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Yasumasa On 2016/05/04 23:38, Marcus Larsson wrote: Hi, On 05/04/2016 04:12 PM, Yasumasa Suenaga wrote: Hi Marcus, 93 out->print("filecount=%u,filesize=" SIZE_FORMAT "%s ", _f

Re: 8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack

Hi Dmitry, Thanks! On 05/09/2016 10:18 PM, Dmitry Samersoff wrote: Robbin, Looks good for me. Did you test the situation when more than one pid returned ? Yes! I actually had test for that but it had same name as yours, so it was overwritten. I'll add it back after FC (and a few more tes

Re: 8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack

Robbin, Looks good for me. Did you test the situation when more than one pid returned ? -Dmitry On 2016-05-09 17:10, Robbin Ehn wrote: > Hi all, > > Please review this enhancement for jinfo, jstack and jmap. > > It is based on top of "8155091: Remove SA related functions from tmtools" > http:

Re: RFR(XXS): 8156226: DiagnosticCommandImpl::invoke throws NoSuchMethodException even if the method actually exists but parameters are wrong

David, Thank you for reviewing the fix! On 05/09/2016 03:08 AM, David Holmes wrote: Hi Kirill, On 7/05/2016 3:39 AM, Kirill Zhaldybin wrote: Alexander, Thank you for reviewing the fix. On 06.05.2016 20:24, Alexander Kulyakhtin wrote: Is there a specification of what shall be thrown, or the

Re: RFR(M): v.05, 8155091: Remove SA related functions from tmtools

> On May 6, 2016, at 6:18 AM, Dmitry Samersoff > wrote: > > Everybody, > > Please, see updated webrev. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.05/ > > Removed ToolProvider interface. run(String ... args) function removed or > renamed to runWithArgs. +1 Mandy

Re: 8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack

Thanks Staffan! /Robbin On 05/09/2016 04:23 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 9 maj 2016, at 16:10, Robbin Ehn wrote: Hi all, Please review this enhancement for jinfo, jstack and jmap. It is based on top of "8155091: Remove SA related functions from tmtools" http:

Re: 8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack

Looks good! Thanks, /Staffan > On 9 maj 2016, at 16:10, Robbin Ehn wrote: > > Hi all, > > Please review this enhancement for jinfo, jstack and jmap. > > It is based on top of "8155091: Remove SA related functions from tmtools" > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-M

8154985: Add the ability to use main class as lookup (as jcmd) to jinfo, jmap, jstack

Hi all, Please review this enhancement for jinfo, jstack and jmap. It is based on top of "8155091: Remove SA related functions from tmtools" http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-May/019609.html Version 5 which is reviewed but not yet pushed: http://cr.openjdk.java.net/~

Re: RFR: 8153535: Convert TraceRedefineClasses to Unified Logging

Hi Coleen, Thanks! I chatted with David, I'll push as is. /Robbin On 05/07/2016 12:51 AM, Coleen Phillimore wrote: Hi Robbin, I think this looks really good and will fit nicely with the logging that I use with class redefinition (wish I had it already!) http://cr.openjdk.java.net/~rehn/81

Re: RFR(s) 8153711: [REDO] JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

Serguei, On Sun, 2016-05-08 at 17:25 -0700, serguei.spit...@oracle.com wrote: > On 5/8/16 03:58, serguei.spit...@oracle.com wrote: > > Severin, > > > > The JPRT job failed: 2016-05-08-100525.sspitsyn.8153711 with a > > NullPointerException. > > The log link is (you can also find the most relevan