Re: RFR (M) 8155951: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool

Hi Coleen, Great fix. Thank you a lot for finding the root causes of these issues! Thanks, Serguei On 5/12/16 11:14, Coleen Phillimore wrote: 8151066: assert(0 <= i && i < length()) failed: index out of bounds Summary: lock classes for redefinition because constant pool merging isn't thread

RFR (M) 8155951: VM crash in nsk/jvmti/RedefineClasses/StressRedefine: assert failed: Corrupted constant pool

8151066: assert(0 <= i && i < length()) failed: index out of bounds Summary: lock classes for redefinition because constant pool merging isn't thread safe, use method constant pool because constant pool merging doesn't make equivalent cpCaches because of invokedynamic I had to make these chang

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

> On 12 maj 2016, at 19:26, Dmitry Samersoff > wrote: > > Alexander, > > jmap doesn't support coredump (non-cooperative) access anymore. This > functionality moved to jhsdb. > > As a long term, we should create two different set of tests - one for > cooperative mode (jmap, jstack, etc) and on

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

Alexander, jmap doesn't support coredump (non-cooperative) access anymore. This functionality moved to jhsdb. As a long term, we should create two different set of tests - one for cooperative mode (jmap, jstack, etc) and one for non-cooperative mode (jhsdb). Cooperative mode tests should resides

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

This looks good. Thanks, Serguei On 5/12/16 06:25, Dmitry Samersoff wrote: Everybody, Please review test changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8156769/webrev.01/ The test is updated to use jhsdb launcher instead of jmap. -Dmitry

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

Hi Dmitry, With this change we are not launching jmap anymore, launching jhsdb instead. I just wanted to make sure if it is ok not to test jmap anymore? Perhaps, instead of changing we should make the test to test both ? Best regards, Alexander - Original Message - From: dmitry.samers...

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

Staffan, > The GC.heap_info Diagnostic Command should really be updated to > contain a lot more information (similar to what SA produces). > Should we file an enhancement for that? I think yes. -Dmitry On 2016-05-12 17:02, Staffan Larsen wrote: > Looks good! > > The GC.heap_info Diagnostic C

Re: RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

Looks good! The GC.heap_info Diagnostic Command should really be updated to contain a lot more information (similar to what SA produces). Should we file an enhancement for that? Thanks, /Staffan > On 12 maj 2016, at 15:25, Dmitry Samersoff > wrote: > > Everybody, > > Please review test ch

RFR(S): JDK-8156769 gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java fails with java.lang.Exception

Everybody, Please review test changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8156769/webrev.01/ The test is updated to use jhsdb launcher instead of jmap. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won

Re: RFR(XXS): 8156777: [TESTBUG] test/testlibrary_tests/SimpleClassFileLoadHookTest.java requires non minimal VM

Chris, Misha, George Thank you for review. Leonid On 12.05.2016 14:21, Christian Tornqvist wrote: Hi Leonid, Change looks good. Thanks, Christian On May 11, 2016, at 12:36 PM, Leonid Mesnik > wrote: Hi Could you please review this extra small fix which a

Re: RFR(XXS): 8156777: [TESTBUG] test/testlibrary_tests/SimpleClassFileLoadHookTest.java requires non minimal VM

Hi Leonid, Change looks good. Thanks, Christian > On May 11, 2016, at 12:36 PM, Leonid Mesnik wrote: > > Hi > > Could you please review this extra small fix which add @requires to the > single test. This test is not compatible with minimal VM even it doesn't > require any specific modules