JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt

2016-08-01 Thread Amy Lu
tools/jlink/JLinkOptimTest.java This test has been removed in JDK-8160829 sun/tools/jinfo/JInfoSanityTest.java sun/tools/jinfo/JInfoRunningProcessFlagTest.java sun/tools/jmap/heapconfig/JMapHeapConfigTest.java These tests have been removed in JDK-8155091 Please review the patch to

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-01 Thread David Holmes
Hi Amit, On 1/08/2016 4:10 PM, Amit Sapre wrote: Hello, Please review JNI exception handling related changes. Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/ Sorry but that's wrong way to fix this. We should

Re: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member

2016-08-01 Thread David Holmes
On 1/08/2016 4:06 PM, Amit Sapre wrote: David, Indeed it is a good to have fix. This API is only used by jdk.management package. Findbugs tool reported this could be potential bug. So made changes accordingly. Yes but Findbugs is not presently module aware so doesn't understand

RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-01 Thread Amit Sapre
Hello, Please review JNI exception handling related changes. Bug id : https://bugs.openjdk.java.net/browse/JDK-8162530 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.00/ Thanks, Amit

RE: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member

2016-08-01 Thread Amit Sapre
David, Indeed it is a good to have fix. This API is only used by jdk.management package. Findbugs tool reported this could be potential bug. So made changes accordingly. Amit. -Original Message- From: David Holmes Sent: Monday, August 01, 2016 6:10 AM To: Amit Sapre; serviceability-dev