Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread David Holmes
Looks good. Sorry I missed this issue in reviewing 8162524. Thanks, David On 2/08/2016 10:58 PM, Markus Gronlund wrote: Greetings, Please review this small fix to address some new issues seen in testing where OOM is erroneously being reported: Bug:

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-02 Thread David Holmes
Hi George, On 3/08/2016 4:49 AM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: There's only one test changed in the webrev ?? JBS: https://bugs.openjdk.java.net/browse/JDK-8160833 Open webrev:

(S) RFR: 8159461: bigapps/Kitchensink/stressExitCode hits assert: Must be VMThread or JavaThread

2016-08-02 Thread David Holmes
webrev: http://cr.openjdk.java.net/~dholmes/8159461/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8159461 The suspend/resume signal (SR_signum) is never sent to a thread once it has started to terminate. On one platform (SuSE 12) we have seen what appears to be a "stuck" signal, which

Re: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-02 Thread David Holmes
Hi Amit, On 2/08/2016 7:49 PM, Amit Sapre wrote: Hello, I have made changes as David suggested. Here is the new webrev link. http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.01/ If the changes are required to pass a JNI code checker then you will also need to check for exceptions

Re: RFR 8160833: ClassesByName2Test.java and RedefineCrossEvent.java failing with jtreg tip

2016-08-02 Thread Daniel D. Daugherty
Adding serviceability-dev@... alias since these are JDI tests... Dan On 8/2/16 12:49 PM, George Triantafillou wrote: Please review this small change to fix test failures in two JDI tests: JBS: https://bugs.openjdk.java.net/browse/JDK-8160833 Open webrev:

RE: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread Markus Gronlund
Thanks Erik! Markus From: Erik Gahlin Sent: den 2 augusti 2016 15:33 To: serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory Looks ok (not a reviewer) Erik On 2016-08-02 14:58, Markus Gronlund wrote:

RE: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread Markus Gronlund
Thanks Dan, not too late at all - I agree with your suggestion and will update accordingly. Thanks again Markus From: Daniel D. Daugherty Sent: den 2 augusti 2016 18:29 To: Markus Gronlund; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean

Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread Daniel D. Daugherty
On 8/2/16 6:58 AM, Markus Gronlund wrote: Greetings, Please review this small fix to address some new issues seen in testing where OOM is erroneously being reported: Bug: https://bugs.openjdk.java.net/browse/JDK-8162945 Changeset: # HG changeset patch # User mgronlun # Date 1470141649

Re: RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread Erik Gahlin
Looks ok (not a reviewer) Erik On 2016-08-02 14:58, Markus Gronlund wrote: Greetings, Please review this small fix to address some new issues seen in testing where OOM is erroneously being reported: Bug: https://bugs.openjdk.java.net/browse/JDK-8162945 Changeset: # HG changeset patch #

RFR(XXS): 8162945: HotspotDiagnosticMXBean getFlags erroneously reports OutOfMemory

2016-08-02 Thread Markus Gronlund
Greetings, Please review this small fix to address some new issues seen in testing where OOM is erroneously being reported: Bug: https://bugs.openjdk.java.net/browse/JDK-8162945 Changeset: # HG changeset patch # User mgronlun # Date 1470141649 -7200 # Tue Aug 02 14:40:49

Re: JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt

2016-08-02 Thread Dmitry Samersoff
Amy, Looks good for me! -Dmitry On 2016-08-02 08:57, Amy Lu wrote: > tools/jlink/JLinkOptimTest.java > This test has been removed in JDK-8160829 > > sun/tools/jinfo/JInfoSanityTest.java > sun/tools/jinfo/JInfoRunningProcessFlagTest.java > sun/tools/jmap/heapconfig/JMapHeapConfigTest.java

Re: JDK 9 RFR of 8161970, 8157664: Remove 4 tools tests from ProblemList.txt

2016-08-02 Thread Sundararajan Athijegannathan
+1 for the jlink test being removed from the problem test. -Sundar On 8/2/2016 11:27 AM, Amy Lu wrote: > tools/jlink/JLinkOptimTest.java > This test has been removed in JDK-8160829 > > sun/tools/jinfo/JInfoSanityTest.java > sun/tools/jinfo/JInfoRunningProcessFlagTest.java >

RE: RFR : JDK-8162530 : src/jdk.management/share/native/libmanagement_ext/GcInfoBuilder.c doesn't handle JNI exceptions properly

2016-08-02 Thread Amit Sapre
Hello, I have made changes as David suggested. Here is the new webrev link. http://cr.openjdk.java.net/~hb/sponsorship/8162530/webrev.01/ Thanks, Amit -Original Message- From: David Holmes Sent: Monday, August 01, 2016 12:33 PM To: Amit Sapre; serviceability-dev Subject: Re: RFR :