Hi all,
This changes has been approved. But it was not passed JPRT.
It is caused by checking return value in
HotSpotVirtualMachine#loadAgentLibrary().
I've fixed it and uploaded webrev. This changes has been passed JPRT. (Thanks
David!)
Could you review again?
hotspot:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8160950
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8160950-JLI-WLS.jdk2/
Summary:
When running a java application with the options `-javaagent:myagent.jar
-Djava.system.classloader=MyClassLoader`
then
Well, it's really up to you guys (serviceability team) regarding whether or not
you want to remove APIs. In this case, though, it seems there is no plan to
remove them, at least not at present, and so the value of forRemoval should be
false.
Since false is the default value of forRemoval, the
Daniel & David,
There is no item/plan in roadmap to remove these deprecated methods. These
methods would remain for reasons which you just described.
It probably makes sense to remove "forRemoval=true" flag. Will wait to hear
from Stuart as well.
Amit
-Original Message-
From: Daniel
Hi Amit,
On 07/09/16 10:34, David Holmes wrote:
Hi Amit,
On 7/09/2016 7:10 PM, Amit Sapre wrote:
Hello,
Please review the changes for missing javadoc updates for deprecated API.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8165579
Webrev :
Hi Amit,
On 7/09/2016 7:10 PM, Amit Sapre wrote:
Hello,
Please review the changes for missing javadoc updates for deprecated API.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8165579
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8165579/webrev.00/
Not sure about the
Hello,
Please review the changes for missing javadoc updates for deprecated API.
Bug Id : https://bugs.openjdk.java.net/browse/JDK-8165579
Webrev : http://cr.openjdk.java.net/~sballal/sponsorship/8165579/webrev.00/
Thanks,
Amit
On 9/7/16 00:45, Dmitry Samersoff wrote:
Serguei,
I'm OK with the fix and OK to be listed as a reviewer.
Thanks, Dmitry!
Serguei
-Dmitry
On 2016-09-07 07:08, serguei.spit...@oracle.com wrote:
Hi Dmitry,
As a sponsor I'm going to push this fix if you are Ok with the fix.
Please, let me
Serguei,
I'm OK with the fix and OK to be listed as a reviewer.
-Dmitry
On 2016-09-07 07:08, serguei.spit...@oracle.com wrote:
> Hi Dmitry,
>
> As a sponsor I'm going to push this fix if you are Ok with the fix.
> Please, let me know if you still have any concerns.
> Also, confirm if you are
On 7/09/2016 1:33 PM, Yasumasa Suenaga wrote:
Hi,
Then you have to add this justification to the bug report and set the
priority to P3.
I've updated JBS.
BTW, the fix looks good to me.
I can sponsor the fix if you have no sponsor yet.
Thanks! I've not had a sponsor for this issue.
10 matches
Mail list logo