Re: RFR : 8182485 - JMX connections should have configurable ObjectInputFilter

Thanks for the review Daniel,Roger. -Harsha On Tuesday 20 June 2017 11:30 PM, Roger Riggs wrote: +1 Roger On 6/20/2017 1:24 PM, Daniel Fuchs wrote: The fix looks good to me Harsha. best regards, -- daniel On 20/06/2017 07:10, Harsha Wardhana B wrote: Hi, Please review the below RFE,

Remove METHOD_ENTRY and METHOD_EXIT events from needed_capabilities in JDWP Agent

  Looking at the Agent_OnLoad() code in debuginit.c of libjdwp, I see that both the METHOD_ENTRY and METHOD_EXIT are listed as required, but I don't see where they are ever enabled in the agent.   In the J9 JVM making it possible to enable these events has severe performance penalties. Since the

Re: RFR : 8182485 - JMX connections should have configurable ObjectInputFilter

+1 Roger On 6/20/2017 1:24 PM, Daniel Fuchs wrote: The fix looks good to me Harsha. best regards, -- daniel On 20/06/2017 07:10, Harsha Wardhana B wrote: Hi, Please review the below RFE, JDK-8182485 : JMX connections should have configurable ObjectInputFilter having webrev at

Re: RFR : 8182485 - JMX connections should have configurable ObjectInputFilter

The fix looks good to me Harsha. best regards, -- daniel On 20/06/2017 07:10, Harsha Wardhana B wrote: Hi, Please review the below RFE, JDK-8182485 : JMX connections should have configurable ObjectInputFilter having webrev at http://cr.openjdk.java.net/~hb/8182485/webrev.00/ The

Re: Review Request JDK-8182596: Fix broken links in com.sun.tools.attach.VirtualMachine

Looks good. Thanks, Serguei On 6/20/17 08:37, Mandy Chung wrote: diff --git a/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java b/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java ---

Re: Review Request JDK-8182596: Fix broken links in com.sun.tools.attach.VirtualMachine

Looks good. On 20/06/2017 16:37, Mandy Chung wrote: diff --git a/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java b/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java --- a/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java +++

Review Request JDK-8182596: Fix broken links in com.sun.tools.attach.VirtualMachine

diff --git a/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java b/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java --- a/src/jdk.attach/share/classes/com/sun/tools/attach/VirtualMachine.java +++

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi Daniel, On Tuesday 20 June 2017 06:39 PM, Daniel Fuchs wrote: On 20/06/2017 12:42, Ujwal Vangapally wrote: Thanks for the Review Daniel, Harsha. Yes with this fix JConsole running on JDK 8 won't be able to connect to a process running on higher version of Java containing this change. I

Re: [10] RFR 8181647: jhsdb jstack could not output thread name

Thank you for checking. However, a few days ago, I have changed the output to be more similar to jstack. Could you possibly check for latest one? Best regards, Chihiro On 2017/06/20 21:16, Jini George wrote: Your changes look good overall, Chihiro. A few points on the test case, though. *

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

On 20/06/2017 12:42, Ujwal Vangapally wrote: Thanks for the Review Daniel, Harsha. Yes with this fix JConsole running on JDK 8 won't be able to connect to a process running on higher version of Java containing this change. I think even Harsha is agreeing this, his point is that the use case

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi, I would expect to see a mix of versions in many operational cases. For example, in a large deployment there will be a mix of versions active and the folks monitoring it should not have to change their management tools unnecessarily. The usual rule for interoperability between versions is

Re: [10] RFR 8181647: jhsdb jstack could not output thread name

Your changes look good overall, Chihiro. A few points on the test case, though. * The test case checks for the existence of the compiler threads and the sweeper thread which would not exist when the test case is run with options like -Xint. You might want to remove those. * You might have to

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Thanks for the Review Daniel, Harsha. Yes with this fix JConsole running on JDK 8 won't be able to connect to a process running on higher version of Java containing this change. I think even Harsha is agreeing this, his point is that the use case where a client running on JDK 8 trying to

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi Harsha, Maybe I'm missing something. How is the local agent started? If it's started when you connect jconsole to a process by specifying the process ID - then I suspect this will prevent e.g. jconsole or jvisualvm running on JDK 8 to connect to your process. Can you verify that it's not

Re: RFR: JDK-8173180 VirtualMachine.startLocalManagementAgent() returns URI with unreliable IP address

Hi Daniel, The fix is applicable only to local JMX agent and the most common use case would be client and server running from same JVM. It is highly unlikely that local JMX agent will be started to cater for out-of-jvm clients. I don't see how introducing this fix can cause new

RFR : 8182485 - JMX connections should have configurable ObjectInputFilter

Hi, Please review the below RFE, JDK-8182485 : JMX connections should have configurable ObjectInputFilter having webrev at http://cr.openjdk.java.net/~hb/8182485/webrev.00/ The enhancement adds ObjectInputFilter to JMX connections to configure filters during deserialization. -Harsha