The updated patch attached.
Now the test is passed with the suggested fix and failed without it.
Thanks,
Serguei
On 8/4/17 15:45, serguei.spit...@oracle.com wrote:
On 8/4/17 14:26, Daniel D. Daugherty wrote:
On 8/4/17 3:17 PM, serguei.spit...@oracle.com wrote:
The patch is attached.
It may n
On 8/4/17 14:26, Daniel D. Daugherty wrote:
On 8/4/17 3:17 PM, serguei.spit...@oracle.com wrote:
The patch is attached.
It may need some tweaks though.
I was not able to make it fail yet.
I don't think the original test had "failure" detection.
You were just supposed to notice that a pending m
Thanks Ioi!
I did forget the bug link:
8185872 quarantine tests named in JDK-8184042 on MacOS X
https://bugs.openjdk.java.net/browse/JDK-8185872
I'm planning to use the "HotSpot Trivial Change" rule for this review.
Dan
On 8/4/17 3:29 PM, Ioi Lam wrote:
Looks good. Thanks Dan!
- Ioi
On 8
Looks good. Thanks Dan!
- Ioi
On 8/4/17 2:24 PM, Daniel D. Daugherty wrote:
Greetings,
I'm quarantining the tests named in JDK-8184042 on MacOS X.
Webrev URL: http://cr.openjdk.java.net/~dcubed/8185872-webrev/0/
This fix is targeted to JDK10/hs.
Dan
On 8/4/17 3:17 PM, serguei.spit...@oracle.com wrote:
The patch is attached.
It may need some tweaks though.
I was not able to make it fail yet.
I don't think the original test had "failure" detection.
You were just supposed to notice that a pending monitor
was listed under the wrong list.
Dan
Greetings,
I'm quarantining the tests named in JDK-8184042 on MacOS X.
Webrev URL: http://cr.openjdk.java.net/~dcubed/8185872-webrev/0/
This fix is targeted to JDK10/hs.
Dan
The patch is attached.
It may need some tweaks though.
I was not able to make it fail yet.
On 8/4/17 12:45, Daniel D. Daugherty wrote:
Thanks Serguei!
I happen to be doing a test run this weekend that includes most of the
JPDA stack of tests so I'll include the following in my experiment:
$ h
Please review this fix for some of the docs for the jdk.jdi module.
Most of the changes are relatively straightforward. The biggest change
was to the introductory tables in the Type and Value classes. These were
both conceptually "many tables in one", with embedded headers within the
tables. T
Thanks Serguei!
I happen to be doing a test run this weekend that includes most of the
JPDA stack of tests so I'll include the following in my experiment:
$ hg log -v -r tip
changeset: 12872:bb66cd7c61b1
tag: 8185164.patch
tag: qtip
tag: tip
user:dcubed
date:
Dan,
Thank you for letting me know about this discussion.
I'll try to convert the attached test case to the JTreg format.
Thanks,
Serguei
On 8/4/17 11:16, Daniel D. Daugherty wrote:
Adding Serguei to this thread directly since he's back from vacation!
On 7/31/17 10:14 PM, David Holmes wrote
Adding Serguei to this thread directly since he's back from vacation!
On 7/31/17 10:14 PM, David Holmes wrote:
Hi Dan,
On 26/07/2017 11:52 PM, Daniel D. Daugherty wrote:
On 7/26/17 12:11 AM, David Holmes wrote:
On 26/07/2017 10:27 AM, Yasumasa Suenaga wrote:
Hi Dan,
I've added some analys
yes will include that in the new webrev.
Thanks,
Ujwal.
On 8/4/2017 8:08 PM, mandy chung wrote:
I haven't reviewed the change. I will look at the new webrev next
week. I think this getThreadInfo method:
getThreadInfo(long[] ids, boolean lockedMonitors, boolean
lockedSynchronizers);
I haven't reviewed the change. I will look at the new webrev next
week. I think this getThreadInfo method:
getThreadInfo(long[] ids, boolean lockedMonitors, boolean
lockedSynchronizers);
should allow specifying the maxDepth too.
Mandy
On 8/3/17 11:30 PM, Ujwal Vangapally wrote:
Thanks
13 matches
Mail list logo
