Hi Daniel,
Your changes look good to me overall. Just some nits:
* Please do add 2018 to the copyright year.
* Since the rest of the file follows 4 spaces for indentation, please
keep the indentation to 4 spaces.
* Line 81: It would be great if the opening brace is at line 80, so that
it would
Thanks Chris. Sorry I already pushed it.
David
On 2/02/2018 12:35 PM, Chris Plummer wrote:
+1
On 2/1/18 12:16 PM, serguei.spit...@oracle.com wrote:
Hi David,
Looks good.
Thank you for taking care about it!
Thanks,
Serguei
On 1/31/18 17:49, David Holmes wrote:
bug: https://bugs.openjdk.ja
+1
On 2/1/18 12:16 PM, serguei.spit...@oracle.com wrote:
Hi David,
Looks good.
Thank you for taking care about it!
Thanks,
Serguei
On 1/31/18 17:49, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8196534
webrev: http://cr.openjdk.java.net/~dholmes/8196534/webrev/
I someh
Thanks Serguei.
David
On 2/02/2018 6:16 AM, serguei.spit...@oracle.com wrote:
Hi David,
Looks good.
Thank you for taking care about it!
Thanks,
Serguei
On 1/31/18 17:49, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8196534
webrev: http://cr.openjdk.java.net/~dholmes/81
On 2/02/2018 1:50 AM, stewartd.qdt wrote:
Please have a look at the newest changes at:
http://cr.openjdk.java.net/~dstewart/8196361/webrev.02/
The only difference between this and the last changeset is the use of "\\R"
instead of whatever is the platform line.separator.
Thanks for that.
Th
Hi Alex,
It looks good.
Just a couple of minor comments though.
109 log("onLoad = " + onLoadValue);
110 log("live= " + liveValue);
111 if (onLoadValue != liveValue || onLoadValue < 0) {
112 throw new RuntimeException("Inconsistent
can_gene
Hi Serguei,
Thanks for the feedback.
Updated fix:
http://cr.openjdk.java.net/~amenkov/can_generate_class_hook/webrev.02/
--alex
On 02/01/2018 11:00, serguei.spit...@oracle.com wrote:
One more attempt to send it with the correct to-list...
Sorry for the noise.
Hi Alex,
It looks good in ge
Hi David,
Looks good.
Thank you for taking care about it!
Thanks,
Serguei
On 1/31/18 17:49, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8196534
webrev: http://cr.openjdk.java.net/~dholmes/8196534/webrev/
I somehow missed these failures when doing the JDK 11 version chan
Hi Alex,
It looks good in general.
A couple of comments on the test.
We had a convention to avoid having test sub-folders with bug numbers.
Could you, please, rename it to some symbolic name?
Also we need the test to fail in the native agent when an error is
reported with the reportError().
One more attempt to send it with the correct to-list...
Sorry for the noise.
Hi Alex,
It looks good in general.
A couple of comments on the test.
We had a convention to avoid having test sub-folders with bug numbers.
Could you, please, rename it to some symbolic name?
Also we need the test to
Please have a look at the newest changes at:
http://cr.openjdk.java.net/~dstewart/8196361/webrev.02/
The only difference between this and the last changeset is the use of "\\R"
instead of whatever is the platform line.separator.
Thank you,
Daniel
-Original Message-
From: David Holmes
Here's a revised webrev
http://cr.openjdk.java.net/~gadams/8080990/webrev.01/index.html
Still testing ...
Using shutdown() fixed problems reported by the
java/nio/channelSocketChannel tests.
I also noticed prior use of getaddrinfo for "localhost" was not calling
freeaddrinfo.
...
On 2/
David,
Thanks for the review. I'll change the split() to look for '\r' instead. I was
unaware of the problems with line.separator, and was actually trying to avoid
cross-platform issues by using it. But things are always more complicated than
they seem!
As far as the original intent of the tes
PING: Could you review and sponsor it?
http://cr.openjdk.java.net/~ysuenaga/JDK-815/webrev.04/
This change has been passed Mach 5 via submit repo:
http://java.se.oracle.com:10065/mdash/jobs/mach5-one-ysuenaga-JDK-815-20180201-0805-10101
Thanks,
Yasumasa
On 2017/11/01 22:02
On 2/1/18, 6:59 AM, Langer, Christoph wrote:
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it?
I still don't see the reason...
vs2013 include/um/winsock2.h has WSASendDisconnect deprecated.
.../src/jdk.jdwp.agent/windows/native/libdt_socket/socket_md.c(230) :
erro
But WSASendDisconnect isn't deprecated, right? So you wanted to get rid of it?
I still don't see the reason...
-Original Message-
From: gary.ad...@oracle.com [mailto:gary.ad...@oracle.com]
Sent: Donnerstag, 1. Februar 2018 12:17
To: Langer, Christoph ; OpenJDK Serviceability
; OpenJDK B
First pass over the code I disabled the compilation flag and then
did quick substitution for the easier functions. I commented out the
WSASendDisconnect calls so I could see what tests would fail if
the function was just removed. I have a replacement now that uses
"shutdown(fd,SD_SEND)", but I sti
Hi Gary,
I was having a look at your changes.
I'm wondering what the reason is behind uncommenting WSASendDisconnect in
Java_sun_nio_ch_SocketDispatcher_preClose0 of file SocketDispatcher.c? And in
dbgsysSocketClose?
In socketTransport.c, line:
331 setLastError(0, "gethostb
On 1/02/2018 5:01 PM, Jini George wrote:
Hello Daniel,
Your fix looks good to me. You probably could instead add 'remove()' or
'run()' to the list, but I leave it upto you.
These tests should only be looking for things that are guaranteed to be
seen. If waitForReferencePendingList is not the
19 matches
Mail list logo
