RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hello, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8198655 http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/ In the end there were two issues. The first was that the pb.redirectError() call was redirecting the LingeredApp's stderr to the console, w

Re: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans

On 3/9/18 4:50 AM, Langer, Christoph wrote: Hi Chris, Secondly, it doesn't accept the assert as length check and complains: fixed_size_dest: You might overrun the 17-character fixed-size string this- _name by copying name without checking the length. Agreed that the assert is not a length chec

Re: RFR: 8196337 Add commit methods that take all event properties as argument

On 09/03/18 15:19, Erik Helin wrote: On 03/09/2018 02:34 PM, Leo Korinth wrote: I still need another reviewer (and a sponsor). Looks good (well XSLT combined with C++ is awful, but the patch is good :D), Reviewed. I can sponsor this patch. Great! Thanks, Leo Thanks, Erik Thanks, Leo

Re: RFR: 8196337 Add commit methods that take all event properties as argument

On 03/09/2018 02:34 PM, Leo Korinth wrote: I still need another reviewer (and a sponsor). Looks good (well XSLT combined with C++ is awful, but the patch is good :D), Reviewed. I can sponsor this patch. Thanks, Erik Thanks, Leo On 08/03/18 10:23, Markus Gronlund wrote: Hi Leo, Looks goo

Re: RFR: 8196337 Add commit methods that take all event properties as argument

Hi Markus, I removed a few newlines (no new webrev). I will use the modified change unless you disagree. I still need another reviewer (and a sponsor). Thanks, Leo On 08/03/18 10:23, Markus Gronlund wrote: Hi Leo, Looks good, thanks for doing this. Sorry for the delay. Cheers Markus

RE: RFR (XS): 8199010: attachListener.hpp: Fix potential null termination issue found by coverity scans

Hi Chris, > > Secondly, it doesn't accept the assert as length check and complains: > > fixed_size_dest: You might overrun the 17-character fixed-size string this- > >_name by copying name without checking the length. > Agreed that the assert is not a length check in product builds. However, > the

Re: PING: RFR: JDK-8153333: [REDO] STW phases at Concurrent GC should count in PerfCounter

Hi Thomas, - one really minor issue I think: in the description in JstatGcCauseResults.java, the descriptions of the new concurrent collections, between "GCT" and "Total Garbage collection time." there should probably be one space less to align with the "main" gc phase times. - in gcCapac

Re: RFR: JDK-8175312: SA: clhsdb: Provide an improved heap summary for 'universe' for G1GC

Here is the revised webrev: http://cr.openjdk.java.net/~jgeorge/8175312/webrev.02/ I have made modifications to have the 'universe' command display details like: hsdb> universe Heap Parameters: garbage-first heap [0x00072520, 0x0007c000] region size 1024K G1 Heap: regions

Re: PING: RFR: JDK-8153333: [REDO] STW phases at Concurrent GC should count in PerfCounter

Hi Yasumasa, On Wed, 2018-03-07 at 21:18 +0900, Yasumasa Suenaga wrote: > PING: Could you review it? > >http://cr.openjdk.java.net/~ysuenaga/JDK-815/webrev.08/ > > JBS: https://bugs.openjdk.java.net/browse/JDK-815 > CSR: https://bugs.openjdk.java.net/browse/JDK-8196862 > > This chan