> Ok. It looks like we don't even have a "jstack --mixed" test. Could you add
> one? It would be even better if the test included a JNI lib that wasn't
> compiled with -fno-omit-frame-pointer so you don't need to rely on glibc to
> reproduce this issue (or is glibc pretty much always compiled w
Hi Coleen,
Now that this had been pushed, I assume JDK-8202896 should be closed as
a dup. And what about JDK-8206076? Is it fixed by this change also?
thanks,
Chris
On 7/30/18 1:49 PM, coleen.phillim...@oracle.com wrote:
Summary: fixed refactoring caused by JDK-8203820
open webrev at http:
A couple nits on
http://cr.openjdk.java.net/~tschatzl/move-serviceability-stuff/webrev/.
g1CollectedHeap.cpp: in initialize_serviceability(), memory_managers(), and
memory_pools(), use g1mm() instead of _g1mm.
g1MonitoringSupport.cpp: there's an extra newline after ~G1MonitoringSupport().
Othe
On 31/07/2018 6:49 AM, coleen.phillim...@oracle.com wrote:
Summary: fixed refactoring caused by JDK-8203820
open webrev at http://cr.openjdk.java.net/~coleenp/8208074.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8208074
For the sake of other readers who don't want to have to rev
Summary: fixed refactoring caused by JDK-8203820
open webrev at http://cr.openjdk.java.net/~coleenp/8208074.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8208074
Ran the test in mach5 on all Oracle supported platforms. Also took the
test out of ProblemList.txt because JDK-8203820
At JVMLS, so can't look in depth this instant, but I'm fine with your approach,
except I'd get the new JMX and jstat structure in place before fixing the data
that gets reported. Imo it'll be easier to fit correct data into the new
JMX/jstat setup than into the old one, and doing it the new way
Chris,
Thanks for the fast review!
Dan
On 7/30/18 2:17 PM, Chris Plummer wrote:
Looks good.
Chris
On 7/30/18 11:05 AM, Daniel D. Daugherty wrote:
Greetings,
I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so
I need a single (R)eviewer for the following fix:
JDK-8208
Looks good.
Chris
On 7/30/18 11:05 AM, Daniel D. Daugherty wrote:
Greetings,
I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so
I need a single (R)eviewer for the following fix:
JDK-8208521 ProblemList more tests that fail due to 'Error attaching to
process
Greetings,
I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so
I need a single (R)eviewer for the following fix:
JDK-8208521 ProblemList more tests that fail due to 'Error attaching to
process: Can't create thread_db agent!'
https://bugs.openjdk.java.net/brow
On 7/30/18 12:47 AM,
serguei.spit...@oracle.com wrote:
Hi Chris,
Just one quick simple comment below.
On 7/29/18 22:05, Chris Plummer wrote:
Hi Gary,
I updated my changes to do the w
Hi Severin,
On 7/30/18 1:28 AM, Severin Gehwolf wrote:
Hi Chris,
On Thu, 2018-07-26 at 14:07 -0700, Chris Plummer wrote:
I had looked at this review when it came out, but was hesitant to ok it
because I really don't know this code at all. If you can get another
reviewer who does know the code,
Hi Paul,
did some prototyping and wanted to show you the results and get your
input:
On Thu, 2018-07-26 at 16:06 +0200, Thomas Schatzl wrote:
>
[...]
> Could we work together on first refactoring the code before adding
> new
> kinds of spaces to the MXBeans?
>
> Looking at this change and min
Hi Chris,
On Thu, 2018-07-26 at 14:07 -0700, Chris Plummer wrote:
> I had looked at this review when it came out, but was hesitant to ok it
> because I really don't know this code at all. If you can get another
> reviewer who does know the code, then I'll approve it.
Sharath Ballal reviewed it,
Hi Chris,
Just one quick simple comment below.
On 7/29/18 22:05, Chris Plummer wrote:
Hi Gary,
I updated my changes to do the wait() for step, stepi, cont, and
next. Some issues turned up when testing. A number of tests w
14 matches
Mail list logo
