On 14/09/2018 01:07, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8210732/webrev.00/index.html
478 lines changed: 3 ins; 319 del; 156 mod;
Hi all,
could you please review the next clean up in jdk testlibrary which removes
jdk.testlibrary.Utils class?
webrev: http://cr.openj
Thanks Alexey for the review, I fixed all the " ," issues that the patch
changed but there are still at least 29 files that seem to have that issue
in the vmTestbase that were not touched by this webrev. I imagine we can do
a refactoring in another webrev (want me to file it?) or we can try to
hand
Hi Igor,
Looks good to me!
Jc
On Thu, Sep 13, 2018 at 5:08 PM Igor Ignatyev
wrote:
> http://cr.openjdk.java.net/~iignatyev//8210732/webrev.00/index.html
> > 478 lines changed: 3 ins; 319 del; 156 mod;
>
> Hi all,
>
> could you please review the next clean up in jdk testlibrary which removes
> j
Hi Jc,
Some notes:
<...>/MethodBind/JvmtiTest/JvmtiTest.cpp
and
<...>/StackTrace/JvmtiTest/JvmtiTest.cpp
have several places with extra space before comma like:
-ret = JVMTI_ENV_PTR(jvmti)->GetStackTrace(JVMTI_ENV_ARG(jvmti,
thr), 0, max_count , stack_buffer, &count);
+ret = jvmti->GetS
http://cr.openjdk.java.net/~iignatyev//8210732/webrev.00/index.html
> 478 lines changed: 3 ins; 319 del; 156 mod;
Hi all,
could you please review the next clean up in jdk testlibrary which removes
jdk.testlibrary.Utils class?
webrev: http://cr.openjdk.java.net/~iignatyev//8210732/webrev.00/ind
Hi JC,
Looks good. Just wanted to point out a couple of argument indentation
choices you made that I like:
280 ret = jvmti->Allocate(sizeof(jvmtiThreadInfo) * threads_count,
281 (unsigned char**)&thread_info);
304 ret = jvmti->GetThreadListStackTraces(
30
From what I can see, jdb.stdout, jdb.session, and the .jtr file all
contain both the jdb output and the debuggee output. I didn't find a
file that contained just the debuggee output. Have you noticed differently?
Chris
On 9/12/18 1:51 PM, Alex Menkov wrote:
+1 for the fix as a temporary work
On 9/13/18 8:39 AM, JC Beyler wrote:
My intent is to finish these macro cleanups (1 more
webrev for the JNI_ENV/JVMTI_ENV in vmTestbase); then I'd like
to do a webrev to remove the remaining #ifdef cplusplus from
vmTestbase (another webrev).
Hi Per,
On 2018/09/13 19:48, Per Liden wrote:
Hi JC,
Thanks for reviewing.
On 09/12/2018 06:02 PM, JC Beyler wrote:
> Hi Per,
>
> I do not know this code but your need to
> call?heapIterationFractionUpdate seems to be a code smell that
> something
> else could be fixed, no?
Patch attached.
On 9/12/18, 3:42 PM, Chris Plummer wrote:
Looks good.
Chris
On 9/12/18 8:20 AM, Gary Adams wrote:
Here's the updated webrev to avoid the NPE, but still
fail the test with more information about the premature
completed threads.
Issue: https://bugs.openjdk.java.net/browse/JDK
Patch attached.
On 9/12/18, 3:35 PM, Chris Plummer wrote:
Looks good. I filed JDK-8210668 to address to root issue.
Chris
On 9/12/18 7:27 AM, Gary Adams wrote:
The print statements in the locals002 test have been observed to
interfere
with the output from commands, replies and prompts used in
Hi JC,
Thanks for reviewing.
On 09/12/2018 06:02 PM, JC Beyler wrote:
Hi Per,
I do not know this code but your need to
call heapIterationFractionUpdate seems to be a code smell that something
else could be fixed, no?
Your webrev looks fine to me if I ignore the code smell that comes from
12 matches
Mail list logo
