RE: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Serguei, Thanks for the review. Thanks, Fairoz > -Original Message- > From: Serguei Spitsyn > Sent: Tuesday, October 02, 2018 11:21 AM > To: Fairoz Matte ; Jini Susan George > ; serviceability-dev@openjdk.java.net > Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on So

Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

Hi Fairoz, It looks good to me. Thanks, Serguei On 9/27/18 10:10 PM, Fairoz Matte wrote: Hi Jini, thanks for the review. May I get one more review for this? Thanks, Fairoz -Original Message- From: Jini George Sent: Friday, September 28, 2018 10:37 AM To: Fairoz Matte ; serviceabi

Re: RFR (M) 8211131: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[G-I]*

Hi Jc, Looking at your conversion script I expected things like if (!NSK_JVMTI_VERIFY( NSK_CPP_STUB2(AddCapabilities, jvmti, &caps))) { to be converted to if (!NSK_JVMTI_VERIFY(jvmti->AddCapabilities(&caps))) { (then the final string is shorter than 100 symbols) But a

Re: RFR JDK-8203928: [Test] Convert non-JDB scaffolding serviceability shell script tests to java

Hi Alex, Looks good. thanks, Chris On 9/27/18 2:32 PM, Alex Menkov wrote: Hi all, please review a fix for https://bugs.openjdk.java.net/browse/JDK-8203928 webrev: http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/ Some details: ImmutableResourceTest.java   - required compile/ru

Re: RFR (M) 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*

On 10/1/18 9:50 AM, JC Beyler wrote: Hi Chris, Thanks for the review! I think most of your comments are/should be future items,

Re: RFR (M) 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*

LGTM --alex On 09/28/2018 19:44, JC Beyler wrote: Hi Alex, Thanks for the review and nice catch. I updated my scripts and now fix that corner case. Here is the incremental webrev that fixes a few more white space issues: Webrev: http://cr.openjdk.java.net/~jcbeyler/8211261/webrev.00_01

Re: RFR (M) 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*

Hi Chris, Thanks for the review! I think most of your comments are/should be future items, I inlined my answers: On Fri, Sep 28, 2018 at 7:49 PM Chris Plummer wrote: > Hi JC, > > In addition to Alex's ForceEarlyReturn001.cpp comment: > > There are many places where I see a space between two pa

Re: Infinite loop in jdk/test/sun/management/windows/revokeall

I'm guessing serviceability-dev is a better place for this message. -- Jon On 10/1/18 5:44 AM, Ladislav Jahoda wrote: Hello guys, the revokeall utility has an infinite loop in its revokeAll method. Please note in the loop (line #344 in revokeall.c): while (count > 0) { the condition (line #