Re: Is RegisterMap updated?

2019-02-01 Thread Jini George
Hi David, This got removed in JDK-9 as a part of SA-JDI removal. (https://bugs.openjdk.java.net/browse/JDK-8158050). Could you let us know as to why are you using SA-JDI ? Thanks, Jini. On 2/1/2019 9:56 PM, David Griffiths wrote: Had a nice simple little reproduction test, went to try it on

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

2019-02-01 Thread David Holmes
On 2/02/2019 4:27 am, z...@redhat.com wrote: After FastTLABRefill was removed, let's cleanup related perf counters. I removed perf counters for fast refill, and renamed perf counters for slow refill. I am not all clear what implication of renaming/removing exported symbols, and have no idea what

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

2019-02-01 Thread zgu
Hi Serguei, Thanks for reviewing. > On Fri, 2019-02-01 at 12:11 -0800, serguei.spit...@oracle.com wrote: > > Hi Zhengyu, > > > > > > > > I do not have enough expertise in this area but it looks good > > to > > me. > > > > > > > > > > > > http://cr.openjdk.

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

2019-02-01 Thread serguei.spit...@oracle.com
Hi Zhengyu, I do not have enough expertise in this area but it looks good to me. http://cr.openjdk.java.net/~zgu/JDK-8212127/webrev.00/src/hotspot/share/gc/shared/threadLocalAllocBuffer.hpp.udiff.html Minor comment: void update_fast_

Re: RFR: JDK-8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out

2019-02-01 Thread serguei.spit...@oracle.com
Hi Gary, The debugee.quit() is to complete the session. It makes this call: sendSignal(SGNL_QUIT); A call to the debugee.quit() is at the end of execTest() method:     display("");     }     display("");     display("=");     display("TEST FINISHES\n");    

RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

2019-02-01 Thread zgu
After FastTLABRefill was removed, let's cleanup related perf counters. I removed perf counters for fast refill, and renamed perf counters for slow refill. I am not all clear what implication of renaming/removing exported symbols, and have no idea what aliasmap is for. So I ran all tests I think c

Re: RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-01 Thread Jini George
Hi Nick, Do we reach here after AARCH64CurrentFrameGuess.run() fails to get the PC ? If so, was wondering if it would make more sense to scan from the top of stack sp obtained from context.getRegisterAsAddress(AARCH64ThreadContext.SP) to the sp of the last known java frame with thread.getLast

RFR: JDK-8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out

2019-02-01 Thread Gary Adams
When the remove_l005 runs to completion, it never signals the debuggee that all iterations have completed. Issue: https://bugs.openjdk.java.net/browse/JDK-8068225 diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++

Re: Is RegisterMap updated?

2019-02-01 Thread David Griffiths
Had a nice simple little reproduction test, went to try it on Java 9 and... oh no, sun.jvm.hotspot.jdi.SACoreAttachingConnector has disappeared! Has it gone for good? Cheers, David On Wed, 30 Jan 2019 at 10:38, Andrew Haley wrote: > > On 1/30/19 10:00 AM, David Griffiths wrote: > > I'm not sure

Re: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-02-01 Thread David Holmes
On 1/02/2019 9:35 pm, Lindenmaier, Goetz wrote: Why do you remove some checks for test failures from some tests? Like serviceability/sa/ClhsdbInspect.java Why won't jstackOutput be null any more after your change? I don't think it can actually be null before the change: ClhsdbLauncher.run c

RE: JDK-8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers

2019-02-01 Thread Lindenmaier, Goetz
> > Why do you remove some checks for test failures from some tests? > > Like > >serviceability/sa/ClhsdbInspect.java > > Why won't jstackOutput be null any more after your change? > > I don't think it can actually be null before the change: > ClhsdbLauncher.run calls ClhsdbLauncher.runCmd whi

RFR: 8209413: AArch64: NPE in clhsdb jstack command

2019-02-01 Thread Nick Gasson (Arm Technology China)
Hi all, Please review this patch to fix a crash in the clhsdb "jstack -v" command on AArch64: Bug: https://bugs.openjdk.java.net/browse/JDK-8209413 Webrev: http://cr.openjdk.java.net/~ngasson/8209413/webrev.01/ On AArch64, if you use "jhsdb clhsdb --pid=..." to attach a debugger to a Java proc